search

Ballsdex-Team / BallsDex-DiscordBot

Collect and exchange countryballs on Discord
Other
85 stars 142 forks source link

[core] For cooldown show active timer #282

Closed Buggem closed 2 months ago

Buggem commented 3 months ago

I imported time because datetime is much more limiting, and kind of useless. Works with Discord, verified it.

flaree commented 3 months ago

I don't see the point in adding this to be honest, it's just adding more computation to something that is just a simple message saying X can be ran in Y seconds.

@laggron42 thoughts?

Buggem commented 3 months ago

I don't see the point in adding this to be honest, it's just adding more computation to something that is just a simple message saying X can be ran in Y seconds.

@laggron42 thoughts?

It currently doesn't tick. My pea-brain struggles to keep count of when it's ready.

flaree commented 2 months ago

Thanks for addressing the changes, much appreciated!

Just checking, if you're aware on how to use pre-commit to run the checks so the build won't fail.

No worries if not! We can do it ourselves, once I'm back from vacation I can do it 😁

Buggem commented 2 months ago

Thanks for addressing the changes, much appreciated!

Just checking, if you're aware on how to use pre-commit to run the checks so the build won't fail.

No worries if not! We can do it ourselves, once I'm back from vacation I can do it 😁

No I don't sorry, could you help (once you get back?)

laggron42 commented 2 months ago

There is documentation in the contribution guide (the pre-commit command must be ran after running poetry shell, otherwise it may not exist).

I did the fix for you in the meantime, just to keep in mind for later!