search

Ballsdex-Team / BallsDex-DiscordBot

Collect and exchange countryballs on Discord
Other
95 stars 157 forks source link

[player] checking if there is an active friend request before sending another one #421

Closed imtherealF1 closed 2 months ago

imtherealF1 commented 2 months ago

closes #424

imtherealF1 commented 2 months ago

I would just use max_concurrency check instead of doing it this way.

issue is, its not available for app_commands, i already tried it, its only for Command, and its something that cant be implemented

ltzmax commented 2 months ago

I would just use max_concurrency check instead of doing it this way.

issue is, its not available for app_commands, i already tried it, its only for Command, and its something that cant be implemented

Oh right, i forgot that has to be coded to have as its own decoder.

imtherealF1 commented 2 months ago

Oh right, i forgot that has to be coded to have as its own decoder.

even if I would code that, the issue is that it wouldn't allow you to send any friend requests to any users after the max concurrency was reached, with this code you can send to any user that you haven't sent an active friend request

ltzmax commented 2 months ago

even if I would code that, the issue is that it wouldn't allow you to send any friend requests to any users after the max concurrency was reached, with this code you can send to any user that you haven't sent an active friend request

Not exactly. you gotta pass it into a class then build the decoder and handlers, i have codes that works with it but dw, we not gonna do that. 📦

ltzmax commented 2 months ago

To me this looks pretty much fine and works, there's been no complains when we added this on a bigger bot than mine (about 800+ server sized bot), but i am also unsure if this is the best way without causing issues. I'll leave this up to review for @laggron42, @Kowlin or @MaxxMXSZ.