search

Baremetrics / calendar

Date range picker for Baremetrics
MIT License
681 stars 79 forks source link

uses a standard naming convention across the source code (camelCase).… #4

Closed gpopoteur closed 9 years ago

gpopoteur commented 9 years ago

… Has backward compatibility when passing the options in snake_case, to make sure it doesn't break current uses of this library.

Inside the source code there is not a naming convention standard for attributes and methods, the names are both in camelCase and snake_case. This PR changes all snake_case names in the source to a more JS friendly camelCase.

Further reading on JS Naming Conventions: Mozilla Developer Network: Javascript Tips Douglas Crockford's code conventions

kalepail commented 9 years ago

Out of personal preference I try and keep all vars as snake_case and all function names as camelCase. Call me weird but that's just my style.

gpopoteur commented 9 years ago

@tyvdh fair enough. Might be cool to add that explanation to the readme file or to a WiKi entry for future reference.