search

Baremetrics / calendar

Date range picker for Baremetrics
MIT License
679 stars 78 forks source link

Fix for #51, should use locale day of week format #54

Closed jonquach closed 7 years ago

jonquach commented 8 years ago

Fix for #51

The format should be the locale day of week, since the operation is done on moment().localeData().

As provided by moment.js documentations: http://momentjs.com/docs/#/displaying/format/

warrenbuckley commented 8 years ago

@jonquach thanks, seems your proposed change is much better than mine here, https://github.com/Baremetrics/calendar/pull/53

Will try your change out in my Fork for the different locales I am working with & then suggest it as the fix

warrenbuckley commented 8 years ago

I tried your change @jonquach and was not able to get it to work as expected. I do not get any errors when clicking on the second date in the date range picker, however the dates in the calendar are mapped to the wrong day/s.

For me today's date Wednesday 18th of May shows up under Tuesday