Baseflow / LottieXamarin

Render After Effects animations natively on Android, iOS, MacOS and TvOS for Xamarin
https://baseflow.com
Apache License 2.0
1.22k stars 261 forks source link

Might have a solution for the Linker #283

Closed taz4270 closed 3 years ago

taz4270 commented 3 years ago

https://github.com/Baseflow/LottieXamarin/blob/b1e1988d243552b74b48b620daa3103643e00f3d/Lottie.Forms/Platforms/Ios/AnimationViewRenderer.cs#L25

Have you tried to do this https://montemagno.com/optimizing-xamarin-apps-libraries-with-the-linker/#preserveeverything ? This might help you a lot and save the users from using unecessary space for a dummy!

martijn00 commented 3 years ago

Can you open a PR for this?

taz4270 commented 3 years ago

Im not able, i dont know why image But i forked it right and made the changes right https://github.com/taz4270/LottieXamarin, make sure to test it out because i dont have all libraries

taz4270 commented 3 years ago

I found the issue, but let me get home later and then i will PR