Baseflow / LottieXamarin

Render After Effects animations natively on Android, iOS, MacOS and TvOS for Xamarin
https://baseflow.com
Apache License 2.0
1.22k stars 261 forks source link

Update Lottie Android to 4.1.0 and fixes build issue #350

Closed 4brunu closed 3 years ago

4brunu commented 3 years ago

:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Updates lottie-android from 3.7.0 to 4.0.0. The change log is here https://github.com/airbnb/lottie-android/blob/master/CHANGELOG.md.

This PR also fixes the build issue by temporarily disabling the JavaSourceJar as mentioned in https://github.com/xamarin/java.interop/issues/850#issuecomment-860707062

1>BINDINGSGENERATOR : error (5: 11): Syntax error, expected: #PCDATA, <tt>, <TT>, <i>, <I>, {@code, {@docRoot}, {@inheritDoc}, {@link, {@linkplain, {@literal, {@value}, {@value, UnknownHtmlElementStart
1>BINDINGSGENERATOR : error (5: 75): Syntax error, expected: #PCDATA, <tt>, <TT>, <i>, <I>, {@code, {@docRoot}, {@inheritDoc}, {@link, {@linkplain, {@literal, {@value}, {@value, UnknownHtmlElementStart, <p>, <P>, <pre>, <PRE>, @author, @apiSince, @deprecated, @deprecatedSince, @exception, @param, @return, @see, @serialData, @serialField, @since, @throws, @[unknown], @version

It fixes those issues https://github.com/Baseflow/LottieXamarin/issues/332 https://github.com/Baseflow/LottieXamarin/issues/343

:arrow_heading_down: What is the current behavior?

:new: What is the new behavior (if this is a feature change)?

:boom: Does this PR introduce a breaking change?

:bug: Recommendations for testing

:memo: Links to relevant issues/docs

:thinking: Checklist before submitting

4brunu commented 3 years ago

@martijn00 could you please publish this new version in nuget? Thanks