search

Baseflow / LottieXamarin

Render After Effects animations natively on Android, iOS, MacOS and TvOS for Xamarin
https://baseflow.com
Apache License 2.0
1.21k stars 261 forks source link

Support for .NET 6 #386

Open markuspalme opened 1 year ago

markuspalme commented 1 year ago

🚀 Feature Requests

The library currently targets Xamarin.iOS but not net6-ios/net6-android. The new TFMs are the future and using this library in new projects is currently not possible.

To address my own very short-term needs I have created a port of the iOS part of this library to .NET 6: https://github.com/markuspalme/LottieNet6/

Platforms affected (mark all that apply)

FreakyAli commented 1 year ago

+1

evgenyvalavin commented 1 year ago

It is not currently possible to use Lottie on net6-ios due to breaking changes in net6-ios: "All code must be recompiled to support .NET 6. Existing assemblies (such as NuGets built for the old TargetFrameworkIdentifier xamarinios10) won’t work and won’t be supported. Non-xamarin specific assets for net4.x, netstandard, netcoreapp, net5.0+, etc. will work fine however." - Link Any plans on rebuilding on .NET 6?

markuspalme commented 1 year ago

@evgenyvalavin I have forked the library and ported it to net6-ios: https://www.nuget.org/packages/Lottie.iOS

But of course an update of this excellent library would be better than a fork long-term.

evgenyvalavin commented 1 year ago

@markuspalme thanks! I already use the NuGet package.

Let's hope together this library will be updated 😄

FreakyAli commented 1 year ago

@markuspalme @evgenyvalavin My understanding of this is that this library will be obsolete and won't be updated to .net 6 at all. Instead, there is a Skia Sharp control that is going to be the Future of Lottie Animations in most .Net environments https://mono.github.io/SkiaSharp.Extended/api/ui-maui/sklottieview.html, I mean obviously, that's not on par with BaseFlow's version but that's the best we have ATM.

Pluxury commented 1 year ago

@FreakyAli How can I use sklottieview in xamarin.native apps ? I think this is not possible and we should wait for the update of this package anyway.

FreakyAli commented 1 year ago

@Pluxury You are right for now this seems to be the case

AdamDiament commented 1 year ago

Does anyone have an android .net6 port for this?

petro2050 commented 1 year ago

@martijn00 what is the current plan for this?

martijn00 commented 1 year ago

I'm more than happy to accept a PR to fix this and release a new version. I've already done some work but can't get iOS to work.

IeuanWalker commented 1 year ago

@martijn00 where is the work you already started and do you remember what problems you were having on iOS?

AdamDiament commented 1 year ago

@martijn00 where is the work you already started and do you remember what problems you were having on iOS?

@IeuanWalker this is the in progress PR. I'm not aware of the specific iOS issues https://github.com/Baseflow/LottieXamarin/pull/379