Baseflow / XamarinMediaManager

Cross platform Xamarin plugin to play and control Audio and Video
https://baseflow.com
MIT License
762 stars 305 forks source link

Enabled setting auto exit full screen when playback completes on iOS … #826

Closed jamsoft closed 1 year ago

jamsoft commented 2 years ago

…cannot find equal functionality on Android in order to implement.

:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)

When video playback on iOS is in full screen mode and the media item completes, the view is auto switched to normal inline view. Without closing full screen first any navigation will fail to actually navigate

:arrow_heading_down: What is the current behavior?

Full screen prevents navigation

:new: What is the new behavior (if this is a feature change)?

Full screen closes at the end of the media item.

:boom: Does this PR introduce a breaking change?

No

:bug: Recommendations for testing

Try setting the value in XAML on VideoView and play full screen video with the MediaItemComplete event handler performing a navigation.

:memo: Links to relevant issues/docs

n/a

:thinking: Checklist before submitting

martijn00 commented 2 years ago

Hmm not sure this is a good way to solve this. Can't you add it as a static on the renderer only for iOS? The current code isn't even implemented properly for Forms...