Fix: Set PlayerNotificationManager up correctly - Githubissues

Baseflow / XamarinMediaManager

Cross platform Xamarin plugin to play and control Audio and Video

https://baseflow.com

MIT License

761 stars 304 forks source link

Fix: Set PlayerNotificationManager up correctly #878

Closed ArchangelWTF closed 1 year ago

ArchangelWTF commented 1 year ago

:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Potential fix for https://github.com/Baseflow/XamarinMediaManager/issues/877 also sets up PlayerNotificationManager in the way Google intends it (Not deprecated)

:arrow_heading_down: What is the current behavior?

Notification doesn't spawn correctly.

:new: What is the new behavior (if this is a feature change)?

Notification should spawn correctly.

:boom: Does this PR introduce a breaking change?

Haven't been able to test yet.

:bug: Recommendations for testing

:memo: Links to relevant issues/docs

:thinking: Checklist before submitting

[ ] All projects build
[ ] Follows style guide lines
[ ] Relevant documentation was updated
[ ] Rebased onto current develop

martijn00 commented 1 year ago

Thanks! I think there is still some more things to fix before I can do a release for MAUI. Maybe you can try to get the new sample running?