Baseflow / XamarinMediaManager

Cross platform Xamarin plugin to play and control Audio and Video
https://baseflow.com
MIT License
761 stars 304 forks source link

Adds step to prepare() when calling PlayQueueItem #910

Open szurgot opened 9 months ago

szurgot commented 9 months ago

Upgrading Windows SDK version to address version downgrade

:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Bug fix.

:arrow_heading_down: What is the current behavior?

When starting a queue from PlayQueueItem, the media plays, but when play is subsequently called, it restarts the queue

:new: What is the new behavior (if this is a feature change)?

Calling pause and play now behave appropriate after starting a queue with PlayQueueItem

:boom: Does this PR introduce a breaking change?

No.

:bug: Recommendations for testing

Test using an app the loads a queue then starts any item with PlayQueueItem.

:memo: Links to relevant issues/docs

https://github.com/Baseflow/XamarinMediaManager/issues/856

:thinking: Checklist before submitting

janwiebe-jump commented 9 months ago

Thanks for looking into this @szurgot Shouldn't the change also be done here?

szurgot commented 9 months ago

Yes. Let me fix that.

szurgot commented 9 months ago

@janwiebe-jump Updated the code so that PlayQueueItem prepares in both instances. Also refactored to eliminate the duplication in those methods.