search

BayAreaMetro / caltrans-typical-weekday-counts

Processing of traffic counts provided by the California Department of Transportation
1 stars 0 forks source link

separate this script into functions and examples #4

Open tbuckl opened 7 years ago

tbuckl commented 7 years ago

this script is a mix of functions, "examples" and a record of data development.

https://github.com/MetropolitanTransportationCommission/caltrans-typical-weekday-counts/blob/master/Consume/get_xy.R

for example, this is a data development step that should be separated out from the main script:

https://github.com/MetropolitanTransportationCommission/caltrans-typical-weekday-counts/blob/master/Consume/get_xy.R#L229

it should also reflect this file name change:

https://github.com/MetropolitanTransportationCommission/caltrans-typical-weekday-counts/commit/416f7a50395c0c23e62438d548e8e00ee630ec38#diff-8d777f385d3dfec8815d20f7496026dc

also, the xy's requiring manual fixes should just be written out as a subset which can be edited and then appended back on the succesful results

tbuckl commented 7 years ago

thanks @lmz for pointing all this out!