Implement a more general form of model argument passing that covers a… (Sourcery refactored)

[sourcery-ai[bot]]

Pull Request #48 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will re-run and update (force-push) this Pull Request with new refactorings as necessary. If Sourcery finds no refactorings at any point, this Pull Request will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

• VS Code
• PyCharm

Review changes via command line

To manually merge these changes, make sure you're on the transformer_models branch, then run:

git fetch origin sourcery/transformer_models
git merge --ff-only FETCH_HEAD
git reset HEAD^

[sourcery-ai[bot]]

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.20%.

Quality metrics	Before	After	Change
Complexity	16.45 🙂	15.81 🙂	-0.64 👍
Method Length	119.88 😞	119.65 🙂	-0.23 👍
Working memory	18.02 ⛔	18.02 ⛔	0.00
Quality	41.76% 😞	41.96% 😞	0.20% 👍

Other metrics	Before	After	Change
Lines	622	623	1

Changed files	Quality Before	Quality After	Quality Change
train.py	29.04% 😞	29.39% 😞	0.35% 👍
utils/metric_tracking.py	56.53% 🙂	56.55% 🙂	0.02% 👍

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
utils/metric_tracking.py	MetricTracker.refresh_best_n_epoch_models	10 🙂	142 😞	18 ⛔	43.22% 😞	Try splitting into smaller methods. Extract out complex expressions
utils/metric_tracking.py	MetricTracker.plot	6 ⭐	184 😞	14 😞	47.14% 😞	Try splitting into smaller methods. Extract out complex expressions
utils/metric_tracking.py	MetricTracker.__init__	7 ⭐	134 😞	15 😞	49.92% 😞	Try splitting into smaller methods. Extract out complex expressions
utils/metric_tracking.py	MetricTracker.collect_per_epoch	11 🙂	129 😞	12 😞	51.04% 🙂	Try splitting into smaller methods. Extract out complex expressions
train.py	get_base_argument_parser	0 ⭐	232 ⛔	9 🙂	58.32% 🙂	Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.