Closed willothy closed 5 months ago
I also have some thoughts to improve the ui-select function, see my config here
I would like to merge my changes with yours and finally to master
, but I am currently a bit busy right now and might do it after one or two weeks.
I also have some thoughts to improve the ui-select function, see my config here
I would like to merge my changes with yours and finally to
master
, but I am currently a bit busy right now and might do it after one or two weeks.
No rush, sounds good! Your changes look good as well, I'll test them out.
@Bekaboo I can also merge your changes into this PR if you'd like, I have some free time this week. If you would prefer to do it that's cool though, no rush.
Sounds cool! You are welcome to do it if you have free time.
Sounds cool! You are welcome to do it if you have free time.
After merging in your changes and trying a few different configurations, I have noticed some edge cases with the way the fzf prompt window opens. These mostly relate to border. I am going to mark this as a draft and do some more work fixing these edge cases, and I'll request review when it's ready. I think I will likely turn all border props into arrays and modify them so that theming can be consistent while still allowing configuration.
Close this by commit 0c3b4f6. Reopen if you have any further improvements or bug fixes.
Totally, sounds good! My bad, didn't end up having time to finish this.
I'll look into the edge cases I found and open a separate PR for those.
win_configs
, not arbitrarily set. Not sure why I had it like that.border == "none"
virt_text
value if it's a table to ensure that multiple return values from string methods likegsub
are ignored.