Bekaboo / dropbar.nvim

IDE-like breadcrumbs, out of the box
GNU General Public License v3.0
896 stars 17 forks source link

fix(ui-select): prompt visibility, border, and fzf menu position #123

Closed willothy closed 5 months ago

willothy commented 6 months ago
  1. Title pos should be based on win_configs, not arbitrarily set. Not sure why I had it like that.
  2. Ensures prompt is always visible by adding a solid top-border if border == "none"
  3. Only uses virt_text value if it's a table to ensure that multiple return values from string methods like gsub are ignored.
Bekaboo commented 6 months ago

I also have some thoughts to improve the ui-select function, see my config here

I would like to merge my changes with yours and finally to master, but I am currently a bit busy right now and might do it after one or two weeks.

willothy commented 6 months ago

I also have some thoughts to improve the ui-select function, see my config here

I would like to merge my changes with yours and finally to master, but I am currently a bit busy right now and might do it after one or two weeks.

No rush, sounds good! Your changes look good as well, I'll test them out.

willothy commented 6 months ago

@Bekaboo I can also merge your changes into this PR if you'd like, I have some free time this week. If you would prefer to do it that's cool though, no rush.

Bekaboo commented 6 months ago

Sounds cool! You are welcome to do it if you have free time.

willothy commented 6 months ago

Sounds cool! You are welcome to do it if you have free time.

After merging in your changes and trying a few different configurations, I have noticed some edge cases with the way the fzf prompt window opens. These mostly relate to border. I am going to mark this as a draft and do some more work fixing these edge cases, and I'll request review when it's ready. I think I will likely turn all border props into arrays and modify them so that theming can be consistent while still allowing configuration.

Bekaboo commented 5 months ago

Close this by commit 0c3b4f6. Reopen if you have any further improvements or bug fixes.

willothy commented 5 months ago

Totally, sounds good! My bad, didn't end up having time to finish this.

I'll look into the edge cases I found and open a separate PR for those.