search

Bekaboo / dropbar.nvim

IDE-like breadcrumbs, out of the box
GNU General Public License v3.0
898 stars 17 forks source link

feat(fzf): allow fzf win_configs to contain functions, fix vertical offsets #131

Closed willothy closed 5 months ago

willothy commented 5 months ago

This PR fixes the issue with fzf placement I mentioned in #123.

willothy commented 5 months ago

Sorry for the confusion, just lots of edge cases here haha. I think it should work now, hopfully I'm not wrong again lol

Bekaboo commented 5 months ago

Sorry for the confusion, just lots of edge cases here haha. I think it should work now, hopfully I'm not wrong again lol

Yeah it's annoying. I think we could simplify the logic by expanding table-valued border whose length is less than 8 to the equivalent border table with 8 elements first then change the borders in different conditions. It can be a utils function in utils/menu.lua.

But let's merge this first.

willothy commented 5 months ago

Yeah, that would definitely make things simpler, as would utilities so we're not repeating any of this border code anywhere.