Closed taimursajid closed 4 years ago
This looks great! Thanks for finding and fixing this bug. Can I ask you to add a unittest? You could use the example above for example. If not I can create one later.
Done.
Merged and updated in pypi (version 0.1.2). Thank you very much!
When adding a new match, prior matches made to
master
anddupe
pairs will also be added to_matches_list
so that new matches flow through.The following toy example demonstrates how the issue:
The existing code will not make add a master-dupe entry for 'microsoftoffice 365 pers' and 'microsoftoffice 365 home' in
_matches_list
, somicrosoftoffice 365 pers
will map to itself.A small change has also been added to the
_matches_list
so that duplicates are dropped.