search

BigDaMa / abstraction-layer

Apache License 2.0
4 stars 8 forks source link

Parameterize method install_tools() #5

Closed FelixNeutatz closed 5 years ago

FelixNeutatz commented 6 years ago

It would be great if we would be able to pass e.g. Postgres user and password as optional parameters of the method install_tools(). If the parameters are specified, we can still ask the user to enter them using raw_input().

m-mahdavi commented 6 years ago

I am curious about the use case of this feature. For example, do you need to call install_tools() from another program? By the way, OK we also consider that.

FelixNeutatz commented 6 years ago

The use case is that I want to run the cleaning API methods in my project :)

m-mahdavi commented 6 years ago

I know. And that is why we try to keep the API functions simple and logical. But, install_tools() method is not a function that you call it every day. :) You need to call it only "once" to install and configure tools on your system. By the way, if you still think for that particular one time, you need to call the function in your project, we will add the arguments to the method. :)

m-mahdavi commented 5 years ago

For now, this method is excluded from the project.