search

BioPhoton / css-star-rating

Css Star Rating is a css only star rating lib based on best practice UX/UI methodes. It is written in scss and fully customizable.
MIT License
69 stars 31 forks source link

1.2.4 - Files are missing #36

Closed Tchoupinax closed 6 years ago

Tchoupinax commented 6 years ago

Hello,

I use angular-star-rating which is using css-star-rating. I found that angular-star-rating is working when using css-start-rating@1.1.3 but has a big problem when compiling css-start-rating@1.2.4

ERROR in ./node_modules/css-loader?{"sourceMap":false,"import":false}!./node_modules/postcss-loader/lib?{"ident":"postcss","sourceMap":false}!./node_modules/sass-loader/lib/loader.js?{"sourceMap":false,"precision":8,"includePaths":[]}!./src/styles.scss
Module build failed: 
@import "~css-star-rating/dist/scss/star-rating.scss";
^
      File to import not found or unreadable: ~css-star-rating/dist/scss/star-rating.scss.
Parent style sheet: /home/[...]/angular/node_modules/angular-star-rating/assets/scss/star-rating.scss
      in /home/[...]/angular/node_modules/angular-star-rating/assets/scss/star-rating.scss (line 1, column 1)
Error: 
@import "~css-star-rating/dist/scss/star-rating.scss";
^
      File to import not found or unreadable: ~css-star-rating/dist/scss/star-rating.scss.
Parent style sheet: /home/[...]/angular/node_modules/angular-star-rating/assets/scss/star-rating.scss
      in /home/[...]/angular/node_modules/angular-star-rating/assets/scss/star-rating.scss (line 1, column 1)
    at options.error (/home/[...]/angular/node_modules/node-sass/lib/index.js:291:26)
 @ ./src/styles.scss 4:14-191
 @ multi ./src/styles.scss

This issue appears with version 1.2.4.

As you can see below, version 1.2.4 is missing a lot of files ! (both versions are downloaded by npm)

1.2.4 css-star-rating's content (Doesn't Work)

 └──     css/ 
 │  ├────     star-rating.css  
 │  └────     star-rating.min.css  
 └──     images/ 
 │  └────     star-rating.icons.svg  
 └──     kss-documentation/ 
 │  ├────     elements.kss.scss  
 │  ├────     modifiers.kss.scss  
 │  ├────     styleguide.kss.scss  
 │  └────     themes.kss.scss  
 ├──     LICENSE  
 ├──     package.json  
 ├──     README.md  
 └──     scss/ 
 │  ├────     _elements.scss  
 │  ├────     _modifiers.scss  
 │  ├────     star-rating.scss  
 │  ├────     _themes.scss  
 │  └────     _variables.scss

1.1.3 css-star-rating's content (Works well !)

 ├──     bower.json  
 ├──     CHANGELOG.md  
 └──     dist/ 
 │  └────     css/ 
 │  │  ├────     star-rating.css  
 │  │  └────     star-rating.min.css  
 │  └────     images/ 
 │  │  └────     star-rating.icons.svg  
 │  └────     scss/ 
 │  │  ├────     _elements.scss  
 │  │  ├────     _modifiers.scss  
 │  │  ├────     star-rating.scss  
 │  │  ├────     _themes.scss  
 │  │  └────     _variables.scss  
 ├──     LICENSE  
 ├──     package.json  
 ├──     README.md  
 └──     resources/ 
 │  └────     images/ 
 │  │  └────     browsers/ 
 │  │  │  ├────     chrome.png  
 │  │  │  ├────     firefox.png  
 │  │  │  ├────     ie.png  
 │  │  │  ├────     opera.png  
 │  │  │  └────     safari.png  
 │  │  ├────     example-usage.gif  
 │  │  ├────     example-usage.PNG  
 │  │  └────     family/ 
 │  │  │  ├────     angular1.png  
 │  │  │  ├────     angular.png  
 │  │  │  └────     css3.png  
 │  │  ├────     prop-animation_speed-immediately.gif  
 │  │  ├────     prop-animation_speed-noticeable.gif  
 │  │  ├────     prop-animation_speed-slow.gif  
 │  │  ├────     prop-color-default.PNG  
 │  │  ├────     prop-color-negative.PNG  
 │  │  ├────     prop-color-ok.PNG  
 │  │  ├────     prop-color-positive.PNG  
 │  │  ├────     prop-direction-ltr.PNG  
 │  │  ├────     prop-direction-rtl.PNG  
 │  │  ├────     prop-disabled-false.PNG  
 │  │  ├────     prop-disabled-true.PNG  
 │  │  ├────     prop-get_color-function.PNG  
 │  │  ├────     prop-labe-hiddel.PNG  
 │  │  ├────     prop-label-bottom.PNG  
 │  │  ├────     prop-label-left.PNG  
 │  │  ├────     prop-label-right.PNG  
 │  │  ├────     prop-label-top.PNG  
 │  │  ├────     prop-label-visible.PNG  
 │  │  ├────     prop-num_of_stars.PNG  
 │  │  ├────     prop-show_half_stars-false.PNG  
 │  │  ├────     prop-show_half_stars-true.PNG  
 │  │  ├────     prop-size-large.PNG  
 │  │  ├────     prop-size-medium.PNG  
 │  │  ├────     prop-size-small.PNG  
 │  │  ├────     prop-space-around.PNG  
 │  │  ├────     prop-space-between.PNG  
 │  │  ├────     prop-space-default.PNG  
 │  │  ├────     prop-text.PNG  
 │  │  ├────     prop-type-custom_icon.PNG  
 │  │  ├────     prop-type-icon.PNG  
 │  │  ├────     prop-type-svg.PNG  
 │  │  ├────     prop-value.PNG  
 │  │  ├────     star-color-default.PNG  
 │  │  ├────     star-color-middle.PNG  
 │  │  ├────     star-color-negative.PNG  
 │  │  ├────     star-color-positive.PNG  
 │  │  ├────     star-empty.png  
 │  │  ├────     star-filled.png  
 │  │  ├────     star-fill-empty.png  
 │  │  ├────     star-fill-filled.PNG  
 │  │  ├────     star-fill-half.PNG  
 │  │  ├────     star-icon-character.PNG  
 │  │  ├────     star-icon-svg.PNG  
 │  │  ├────     star-rating-options.PNG  
 │  │  ├────     star-size-larg.PNG  
 │  │  ├────     star-size-medium.PNG  
 │  │  └────     star-size-small.PNG  
 └──     src/ 
 │  └────     assets/ 
 │  │  └────     star-rating.icons.svg  
 │  └────     sc5-styleguide/ 
 │  │  ├────     elements.sc5.scss  
 │  │  ├────     modifiers.sc5.scss  
 │  │  ├────     styleguide.scss  
 │  │  ├────     styles.css  
 │  │  └────     themes.scss  
 │  └────     scss/ 
 │  │  ├────     _elements.scss  
 │  │  ├────     _modifiers.scss  
 │  │  ├────     star-rating.scss  
 │  │  ├────     _themes.scss  
 │  │  └────     _variables.scss

Can you fix it please ? Thank you for your work. :)

Have a nice day !

dak commented 6 years ago

The issue here I believe is that the main file in package.json was changed from dist/css/star-rating.css to css/star-rating.css (which doesn't exist).

See: https://github.com/BioPhoton/css-star-rating/pull/32