Closed quanaibn closed 5 years ago
Hi @quanaibn
Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.
The DESCRIPTION file for this package is:
Package: scGPS
Type: Package
Title: An implementation of clustering and subpopulation relationship analysis (scGPS = single cell Global Predictions of Subpopulation)
Version: 0.99.0
Authors@R: c(
person("Quan", "Nguyen", email="quan.nguyen@uq.edu.au", role=c("aut", "cre")),
person("Michael", "Thompson",role=c("aut")),
person("Anne", "Asenbouth",role=c("aut"))
)
Description: The package implements two main algorithms to answer two key questions: a CORE (Clustering at Optimal REsolution) to find subpopulations, followed by scGPS to investigate the relationships between subpopulations. A compatible software that can run CORE is ascend R package.
Encoding: UTF-8
LazyData: true
License: GPL-3
BugReports: https://github.com/IMB-Computational-Genomics-Lab/scGPS/issues
url: https://github.com/IMB-Computational-Genomics-Lab/scGPS/
RoxygenNote: 6.1.1
Depends: R (>= 3.5), SummarizedExperiment, dynamicTreeCut, SingleCellExperiment
biocViews: SingleCell, Clustering, DataImport, Sequencing, Coverage
Imports:
glmnet (> 2.0),
caret (>= 6.0),
ggplot2 (>= 2.2.1),
fastcluster,
dplyr,
Rcpp,
RcppArmadillo,
RcppParallel,
grDevices,
graphics,
stats,
utils,
DESeq,
locfit
Suggests:
Matrix (>= 1.2),
testthat,
knitr,
cidr,
parallel,
rmarkdown,
RColorBrewer,
ReactomePA,
clusterProfiler,
cowplot,
org.Hs.eg.db,
reshape2,
xlsx,
dendextend,
networkD3,
Rtsne,
BiocParallel,
e1071,
WGCNA,
devtools,
DOSE
VignetteBuilder: knitr
LinkingTo:
Rcpp,
RcppArmadillo,
RcppParallel
SystemRequirements: GNU make
Add SSH keys to your GitHub account. SSH keys will are used to control access to accepted Bioconductor packages. See these instructions to add SSH keys to your GitHub account.
A reviewer has been assigned to your package. Learn what to expect during the review process.
IMPORTANT: Please read the instructions for setting up a push hook on your repository, or further changes to your repository will NOT trigger a new build.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
bf70b01 trigger build
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Hi Quan, @quanaibn Thank you for your submission. Please resolve the package errors in the report.
Best regards, Marcel
Received a valid push; starting a build. Commits are:
f5a8e88 bump version
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "TIMEOUT, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
8dc0873 bump version number
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, TIMEOUT, WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
174e76f bump version, speed up the build
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
d752e9b version bump
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "TIMEOUT, WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
75c5f8b bump version for rebuild
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
1cff973 bump version
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
77be0c2 bump version rebuild
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
9a71e64 bump version rebuild
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
85ca05c bump version shorter vignette for reduilding
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
646660d bump version
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
Hi Marcel Ramos,
Finally the package has passed all the build requirements. Could you please advise what do I need to do next?
Thanks very much for your help and I look forward to your response.
Best wishes,
Quan
Hi Quan, @quanaibn Thank you for your submission to Bioconductor. Please see the review below.
Add comments in this thread if you have any questions.
Best regards, Marcel
NewscGPS
appear confusing based on the name alone_scGPS
suffixdevtools::install
and a library(scGPS)
call. devtools::document
should
only be used to update the documentation pages and devtools::load_all()
is
not the right way to load the packageinst/resources
folder, for
examplesessionInfo
chunk to the vignetteX <- vector(); X[i] <- y
:
https://www.bioconductor.org/developers/how-to/efficient-code/message
instead of print
within functionsscaling
to the stats::prcomp
function rather than
using a condition scaling == TRUE
(See minor point below)CIDR
or provide a working alternativeSummarizedExperiment
inputs where possible especially for expression
matrix argumentsmtcars[["mpg"]]
is preferred over mtcars[[1]]
verbose
argument in your functionsadd_import
rather than using NULL
?Minor:
if
conditions without redundancy if (LDA_run)
is preferred over
if (LDA_run == TRUE)
and !is.matrix(x)
over is.matrix(x) == FALSE
sample1
, sample2
, and GeneList
if
possibleHi Quan, @quanaibn
Any updates on the package status? Do you intend to work on the package?
Thanks for letting us know.
Best, Marcel
Hi Marcel, Yes, we will work on the package. It was a hectic few weeks for us to work on grant applications. Do we have a chance to meet the Bioconductor release deadline? Many thanks! Quam
On Tue, Apr 30, 2019 at 3:46 AM Marcel Ramos notifications@github.com wrote:
Hi Quan, @quanaibn https://github.com/quanaibn
Any updates on the package status? Do you intend to work on the package?
Thanks for letting us know.
Best, Marcel
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Bioconductor/Contributions/issues/1042#issuecomment-487676796, or mute the thread https://github.com/notifications/unsubscribe-auth/AB6U7UANU5JHCO6Y76R7VHLPS4X6HANCNFSM4G5RC4CA .
Hi Quan, @quanaibn
The deadline to get reviewed packages into the next release was April 24 (as on the website):
You can still submit your package to the devel branch of Bioconductor.
Best regards, Marcel
Hi Marcel, That's ok, we'll aim for the next release. We will start addressing your comments from next week after submitting the grants. Thanks very much! Quan
On Wed, May 1, 2019 at 5:48 AM Marcel Ramos notifications@github.com wrote:
Hi Quan, @quanaibn https://github.com/quanaibn
The deadline to get reviewed packages into the next release was April 24 (as on the website): Wednesday April 24
- No API changes to Bioc 3.9.
- Deadline to add new packages to the BiocC 3.9 manifest.
You can still submit your package to the devel branch of Bioconductor.
Best regards, Marcel
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Bioconductor/Contributions/issues/1042#issuecomment-488090254, or mute the thread https://github.com/notifications/unsubscribe-auth/AB6U7UCJKHTB3G753X7ZNEDPTCPBJANCNFSM4G5RC4CA .
Hi Marcel,
We are working on addressing all of your comments. We will have the revised version ready on Friday. Could you advise us how to address your comments below and still keep the compilation file under 5 minutes:
1) "Do not include unevaluated code in the vignette. This code can become stale quickly without constant evaluation" -> Our full vignette will make the compilation time exceeds 5 minutes, so we commented out some codes to save the compilation time. Do you have advice about a better option?
Many thanks!
Quan
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
Hi Marcel,
We've attempted to address most of your comments. The new version has been updated.
There are 4 items that we haven't completely addressed yet. Could you let us know if we need to address them further:
Hope to hear from you soon,
Best wishes,
Quan
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
e850d3f bump version
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Received a valid push; starting a build. Commits are:
56c96ca version bump
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the build report for more details.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
Congratulations! The package built without errors or warnings on all platforms.
Please see the build report for more details.
Hi Marcel,
We are waiting for your responses to complete our submission. Could you please comment on the current version?
Many thanks,
Quan
Hi Marcel,
If you are busy and unable to comment. Could you please suggest another curator at Bioconductor? Thanks!
Quan
Hi Quan, @quanaibn Apologies for the delay. I was traveling last week. I will respond to your questions. Briefly, you can go over the 5 minute limit without problems. I will have another look at your package soon.
Best, Marcel
Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor
Confirm the following by editing each check box to '[x]'
[x] I understand that by submitting my package to Bioconductor, the package source and all review commentary are visible to the general public.
[ x] I have read the Bioconductor Package Submission instructions. My package is consistent with the Bioconductor Package Guidelines.
[x] I understand that a minimum requirement for package acceptance is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS. Passing these checks does not result in automatic acceptance. The package will then undergo a formal review and recommendations for acceptance regarding other Bioconductor standards will be addressed.
[x] My package addresses statistical or bioinformatic issues related to the analysis and comprehension of high throughput genomic data.
[x] I am committed to the long-term maintenance of my package. This includes monitoring the support site for issues that users may have, subscribing to the bioc-devel mailing list to stay aware of developments in the Bioconductor community, responding promptly to requests for updates from the Core team in response to changes in R or underlying software.
I am familiar with the essential aspects of Bioconductor software management, including:
For help with submitting your package, please subscribe and post questions to the bioc-devel mailing list.