Bioconductor / Contributions

Contribute Packages to Bioconductor
135 stars 33 forks source link

SurfR #3105

Closed auroramaurizio closed 9 months ago

auroramaurizio commented 1 year ago

Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

I am familiar with the essential aspects of Bioconductor software management, including:

For questions/help about the submission process, including questions about the output of the automatic reports generated by the SPB (Single Package Builder), please use the #package-submission channel of our Community Slack. Follow the link on the home page of the Bioconductor website to sign up.

bioc-issue-bot commented 1 year ago

Hi @auroramaurizio

Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: SurfR
Type: Package
Title: Surface Protein Prediction and Identification
Version: 0.99.0
Authors@R:c(person("Aurora", "Maurizio", email="auroramaurizio1@gmail.com", role = c("aut","cre")),
 person("Anna Sofia", "Tascini", email="volpesofi@gmail.com", role = c("aut", "ctb")))
Description: Identify Surface Protein coding genes from a list of candidates.
   Systematically download data from GEO and TCGA or use your own data. 
   Perform DGE on bulk RNAseq data. 
   Perform Meta-analysis. Descriptive enrichment analysis and plots.
License: GPL-3 + file LICENSE
Encoding: UTF-8
LazyData: false
biocViews: Software, Sequencing, RNASeq, GeneExpression, Transcription, DifferentialExpression, 
 PrincipalComponent, GeneSetEnrichment, Pathways, BatchEffect,
 FunctionalGenomics, Visualization, DataImport
VignetteBuilder: knitr
RoxygenNote: 7.2.3
Imports:
  httr,
  SPsimSeq,
  DESeq2,
  edgeR,
  rio,
  openxlsx,
  stringr,
  rhdf5,
  ggplot2,
  ggrepel,
  stats,
  magrittr,
  assertr,
  tidyr,
  dplyr,
  TCGAbiolinks,
  biomaRt,
  metaRNASeq,
  enrichR,
  scales,
  venn,
  gridExtra,
  SummarizedExperiment,
  knitr,
  grDevices, 
  graphics, 
  utils
bioc-issue-bot commented 1 year ago

A reviewer has been assigned to your package. Learn what to expect during the review process.

IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. It is required to push a version bump to git.bioconductor.org to trigger a new build.

Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build System: ERROR before build products produced.

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/SurfR to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 1 year ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 8d44c6b00562d4cee1af41ffbc00842a899434c5

auroramaurizio commented 1 year ago

Dear @PeteHaitch,

Thank you for the feedback.

We fixed the linux-platform issue in the vignette and submitted the updated version.

We have tested the package on a local Mac OS computer and the R CMD check succeeded. At the end of this message we report the sessionInfo(). Unfortunately, we could not reproduce the mac-related error highlighted in the lconway BUILD SRC output: "Rhdf5lib was not compiled with support for the S3 VFD". We read the chat between you and a former package submitter addressing the same topic https://github.com/Bioconductor/Contributions/issues/2753 (and checked the package source) as well as several posts by Mike Smith such as https://support.bioconductor.org/p/9134972/#9153888. It seems more like a macOS-Rhdf5 related problem. What's your advice?

Best wishes,

Aurora and Anna Sofia

sessionInfo() R version 4.3.1 (2023-06-16) Platform: x86_64-apple-darwin20 (64-bit) Running under: macOS Monterey 12.6.3

Matrix products: default BLAS: /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libBLAS.dylib LAPACK: /Library/Frameworks/R.framework/Versions/4.3-x86_64/Resources/lib/libRlapack.dylib; LAPACK version 3.11.0

locale: [1] en_US.UTF-8/en_US.UTF-8/en_US.UTF-8/C/en_US.UTF-8/en_US.UTF-8

time zone: Europe/Rome tzcode source: internal

attached base packages: [1] stats graphics grDevices utils datasets methods base

other attached packages: [1] stringr_1.5.0 SPsimSeq_1.10.0 SurfR_0.99.0 BiocManager_1.30.22

loaded via a namespace (and not attached): [1] splines_4.3.1 bitops_1.0-7 filelock_1.0.2 tibble_3.2.1 cellranger_1.1.0
[6] preprocessCore_1.62.1 XML_3.99-0.14 rpart_4.1.19 lifecycle_1.0.3 fastcluster_1.2.3
[11] edgeR_3.42.4 doParallel_1.0.17 lattice_0.21-8 MASS_7.3-60 backports_1.4.1
[16] magrittr_2.0.3 openxlsx_4.2.5.2 limma_3.56.2 Hmisc_5.1-0 rmarkdown_2.24
[21] zip_2.3.0 DBI_1.1.3 ade4_1.7-22 abind_1.4-5 zlibbioc_1.46.0
[26] rvest_1.0.3 GenomicRanges_1.52.0 purrr_1.0.2 metaRNASeq_1.0.7 BiocGenerics_0.46.0
[31] RCurl_1.98-1.12 phyloseq_1.44.0 nnet_7.3-19 WriteXLS_6.4.0 rappdirs_0.3.3
[36] GenomeInfoDbData_1.2.10 IRanges_2.34.1 S4Vectors_0.38.1 ggrepel_0.9.3 vegan_2.6-4
[41] venn_1.11 fitdistrplus_1.1-11 permute_0.9-7 codetools_0.2-19 DelayedArray_0.26.7
[46] xml2_1.3.5 tidyselect_1.2.0 TCGAbiolinksGUI.data_1.20.0 matrixStats_1.0.0 stats4_4.3.1
[51] BiocFileCache_2.8.0 dynamicTreeCut_1.63-1 base64enc_0.1-3 jsonlite_1.8.7 multtest_2.56.0
[56] Formula_1.2-5 survival_3.5-7 iterators_1.0.14 foreach_1.5.2 tools_4.3.1
[61] progress_1.2.2 rio_0.5.30 Rcpp_1.0.11 glue_1.6.2 gridExtra_2.3
[66] admisc_0.33 xfun_0.40 mgcv_1.9-0 DESeq2_1.40.2 MatrixGenerics_1.12.3
[71] GenomeInfoDb_1.36.2 dplyr_1.1.3 fastmap_1.1.1 rhdf5filters_1.12.1 fansi_1.0.4
[76] digest_0.6.33 R6_2.5.1 colorspace_2.1-0 GO.db_3.17.0 biomaRt_2.56.1
[81] RSQLite_2.3.1 utf8_1.2.3 tidyr_1.3.0 generics_0.1.3 data.table_1.14.8
[86] prettyunits_1.1.1 httr_1.4.7 htmlwidgets_1.6.2 S4Arrays_1.0.6 pkgconfig_2.0.3
[91] gtable_0.3.4 blob_1.2.4 impute_1.74.1 SingleCellExperiment_1.22.0 XVector_0.40.0
[96] htmltools_0.5.6 biomformat_1.28.0 scales_1.2.1 Biobase_2.60.0 png_0.1-8
[101] enrichR_3.2 knitr_1.43 rstudioapi_0.15.0 tzdb_0.4.0 reshape2_1.4.4
[106] rjson_0.2.21 checkmate_2.2.0 nlme_3.1-163 curl_5.0.2 cachem_1.0.8
[111] rhdf5_2.44.0 parallel_4.3.1 foreign_0.8-84 AnnotationDbi_1.62.2 pillar_1.9.0
[116] grid_4.3.1 vctrs_0.6.3 dbplyr_2.3.3 cluster_2.1.4 htmlTable_2.4.1
[121] evaluate_0.21 TCGAbiolinks_2.28.3 readr_2.1.4 mvtnorm_1.2-3 cli_3.6.1
[126] locfit_1.5-9.8 compiler_4.3.1 rlang_1.1.1 crayon_1.5.2 assertr_3.0.0
[131] plyr_1.8.8 forcats_1.0.0 stringi_1.7.12 WGCNA_1.72-1 BiocParallel_1.34.2
[136] munsell_0.5.0 Biostrings_2.68.1 Matrix_1.6-1 hms_1.1.3 bit64_4.0.5
[141] ggplot2_3.4.3 Rhdf5lib_1.22.0 KEGGREST_1.40.0 SummarizedExperiment_1.30.2 haven_2.5.3
[146] igraph_1.5.1 memoise_2.0.1 bit_4.0.5 readxl_1.4.3 downloader_0.4
[151] ape_5.7-1

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build System: Linux (Ubuntu 22.04.2 LTS): SurfR_0.99.1.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/SurfR to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 1 year ago

Received a valid push on git.bioconductor.org; starting a build for commit id: acf8a50bc5fd393b36a571b2be58056de10d8db5

bioc-issue-bot commented 1 year ago

Received a valid push on git.bioconductor.org; starting a build for commit id: acf8a50bc5fd393b36a571b2be58056de10d8db5

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "ABNORMAL". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build System: ERROR before build products produced.

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/SurfR to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 1 year ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 5a0f525af984db421c28f2809f6416373ea09cf4

bioc-issue-bot commented 1 year ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 5a0f525af984db421c28f2809f6416373ea09cf4

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "ABNORMAL". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build System: ERROR before build products produced.

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/SurfR to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build System: ERROR before build products produced.

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/SurfR to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build System: Linux (Ubuntu 22.04.2 LTS): SurfR_0.99.1.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/SurfR to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

auroramaurizio commented 1 year ago

Dear @PeteHaitch, It seems there might be a discrepancy between the package version in the build report and the actual version in the repositories. Looking at the build report we noticed that the check is still made on package version 0.99.1 while the current version is 0.99.3. We pushed the latest version on both origin and upstream repos. Cloning https://git.bioconductor.org/packages/SurfR.git we see that everithing is up to date: the corrections have been implemented (removing SurfR.Proj file and updating .gitignore) and the version in DESCRIPTION is the latest 0.99.3. Only the check on the build report is made on the old version 0.99.1.

Thank you for your attention to this matter.

Best, Aurora and Anna Sofia

PeteHaitch commented 1 year ago

@lshep any idea about why an old version is getting picked up by the build system (see https://github.com/Bioconductor/Contributions/issues/3105#issuecomment-1715127737)

lshep commented 1 year ago

It looks like something odd is going in; in particular also with the double build report kick off. yet we don't see this with other repositories. how exactly are you making changes and pushing to git.bioconductor.org?

auroramaurizio commented 1 year ago

Dear @lshep, Thank you for your quick reply.

Here the commands:

git remote -v

origin git@github.com:auroramaurizio/SurfR.git (fetch)

origin git@github.com:auroramaurizio/SurfR.git (push)

upstream git@git.bioconductor.org:packages/SurfR.git (fetch)

upstream git@git.bioconductor.org:packages/SurfR.git (push)

git fetch --all git merge origin/master git merge upstream/master git add . git commit -m "bumped the package version 0.99.3" git push origin master git push upstream master git push upstream master:devel

I think the double report kick off is due to the fact that I pushed to master instead of devel at first. I got this message in the last commit:

git push upstream master

Counting objects: 5, done.

Delta compression using up to 8 threads.

Compressing objects: 100% (3/3), done.

Writing objects: 100% (3/3), 302 bytes | 0 bytes/s, done.

Total 3 (delta 2), reused 0 (delta 0)

remote: Use of 'master' branch is deprecated on git.bioconductor.org;

remote: Access to 'master' will eventually be revoked.

remote: Please use 'devel' to update Bioconductor devel version.

remote: See: http://contributions.bioconductor.org/branch-rename-faqs.html

To git@git.bioconductor.org:packages/SurfR.git

acf8a50..5a0f525 master -> master

git push upstream master:devel

Total 0 (delta 0), reused 0 (delta 0)

To git@git.bioconductor.org:packages/SurfR.git

acf8a50..5a0f525 master -> devel

I'll move to devel as prompt here http://contributions.bioconductor.org/branch-rename-faqs.html. Hope it solves the issue.

Best, Aurora

lshep commented 1 year ago

Yes please only push to the devel branch on git.bioconductor.org. We do encourage you to change your default branch on github to devel to be consistent and may also help clear things up. I'll monitor and see when there are future pushes. In the meantime, I'll kick off a manual build to hopefully get the current version's report.

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build System: Linux (Ubuntu 22.04.2 LTS): SurfR_0.99.3.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/SurfR to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

auroramaurizio commented 1 year ago

Dear Pete, Thank you for taking action towards the resolution of the "Rhdf5lib-mac" issue in the bc build report (https://github.com/Bioconductor/BBS/issues/245). The build/check report was successful on the Linux machine. Please let us know if there is something else we can do in the meanwhile. Best, Aurora

PeteHaitch commented 1 year ago

Hi Aurora,

You might address some of the NOTEs raised by running BiocCheck::BiocCheck() on the package (the results are listed in the build report). I'm not too worried about the code styling recommendations, that's largely personal preference, but there are other recommendations that are worth following.

I'll post my full review by the end of next week at the latest.

Cheers, Pete

bioc-issue-bot commented 1 year ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 5a23b73edda6fa7e5e760127f907556e0fc14114

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build System: ERROR before build products produced.

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/SurfR to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 1 year ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 58716b578c44b7fe3edb7229cdb15cfc0edba85b

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build System: ERROR before build products produced.

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/SurfR to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

auroramaurizio commented 1 year ago

Dear Pete, we've started addressing the BiocCheck notes, but we've encountered a new issue. The code is now failing during both linux and mac bioconductor builds/checks. We tested it on our local computers and cluster and it works fine. The issue appears to be centered around the function "Gene2SProtein" in the vignette quickstart, which wasn't affected by the recent small code updates. Since this function downloads a table from an url (the url is still accessible and functioning) could the error be due to newly occurred connectivity issues ?

Thank you for your assistance, Aurora

PeteHaitch commented 1 year ago

You might try triggering a new build of the package to see if it was an intermittent connectivity issue. You can do this by bumping the version number and pushing to the BioC git server.

lshep commented 1 year ago

FWIW -- to prevent this sort of thing from occurring too we highly recommend caching anything downloaded from external urls.

bioc-issue-bot commented 1 year ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 22e777a337b9244e880f0f44d8cc46e76e786a01

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build System: ERROR before build products produced.

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/SurfR to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 1 year ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 3bd8748b9444dbb46f63de90ac3edd1073e11148

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build System: ERROR before build products produced.

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/SurfR to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 1 year ago

Received a valid push on git.bioconductor.org; starting a build for commit id: ef891acb2ed5fa65ddc32a4a89e789d95989a3a6

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build System: ERROR before build products produced.

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/SurfR to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 1 year ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 61062ea3b60c305984a0126d8410acab7c8ee65f

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build System: ERROR before build products produced.

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/SurfR to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 1 year ago

Received a valid push on git.bioconductor.org; starting a build for commit id: a3b627bb7105458d8011b798134d97b3b3fd419d

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build System: ERROR before build products produced.

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/SurfR to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

PeteHaitch commented 1 year ago

@auroramaurizio I'm going on leave today and will be offline until Oct 9. Your package will be re-assigned by @lshep to someone else for review.

bioc-issue-bot commented 1 year ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 5ed8cb5c98ea622c048ae6c28debb3822e0b2384

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build System: ERROR before build products produced.

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/SurfR to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 1 year ago

Received a valid push on git.bioconductor.org; starting a build for commit id: ba5e0a2787ae9df5f1c23ca00a5750964bea4c59

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build System: Linux (Ubuntu 22.04.2 LTS): SurfR_0.99.12.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/SurfR to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 1 year ago

Received a valid push on git.bioconductor.org; starting a build for commit id: fd4e6e286782787ef5a9bf3f9ddc4f50f8b1a705

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build System: ERROR before build products produced.

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/SurfR to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 1 year ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 32cfcb852861aadb11138ab1512555b18f0f0357

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build System: Linux (Ubuntu 22.04.2 LTS): SurfR_0.99.14.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/SurfR to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

auroramaurizio commented 1 year ago

Dear @PeteHaitch, Thank you for your time and attention to our package.

The check is now successful on the linux builder. I see that the issue https://github.com/Bioconductor/BBS/issues/245 about the Iconway Mac builder configuration is still open. In the meanwhile, as you suggested me, I addressed several nebbiolo2 BiocCheck notes.

Best, Aurora

auroramaurizio commented 1 year ago

Dear @lshep,

I am reaching out to follow up on the communication from our former reviewer, Peter Hickey. Peter informed us that he is currently on leave and that a new reviewer will be assigned to our package.

With the upcoming 3.18 Bioconductor package release approaching, do you think SurfR package could be considered for revision even if it passes the Linux nebbiolo2 check but Iconway macOS check is currently infeasible due to the builder issue outlined here https://github.com/Bioconductor/BBS/issues/245#issuecomment-1721605029? We tested it on our macOS laptops and the checks were successful (e.g. https://github.com/Bioconductor/Contributions/issues/3105#issuecomment-1713954422).

I appreciate your input and guidance.

Thank you, Aurora