Bioconductor / Contributions

Contribute Packages to Bioconductor
135 stars 33 forks source link

recountWorkflow #421

Closed lcolladotor closed 7 years ago

lcolladotor commented 7 years ago

Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor

Note that this package is a workflow and not a software package.

Confirm the following by editing each check box to '[x]'

I am familiar with the essential aspects of Bioconductor software management, including:

For help with submitting your package, please subscribe and post questions to the bioc-devel mailing list.

bioc-issue-bot commented 7 years ago

Hi @lcolladotor

Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: recountWorkflow
Title: recount workflow: accessing over 70,000 human RNA-seq samples with
    Bioconductor
Version: 0.99.0
Authors@R: c(person("Leonardo", "Collado-Torres", role = c("aut", "cre"),
    email = "lcollado@jhu.edu"), person("Abhinav", "Nellore", role = "ctb",
    email = "anellore@gmail.com"), person(c("Andrew", "E."), "Jaffe",
    role = "ctb", email = "andrew.jaffe@libd.org"))
Description: The recount2 resource is composed of over 70,000 uniformly
    processed human RNA-seq samples spanning TCGA and SRA, including GTEx. The
    processed data can be accessed via the recount2 website and the recount 
    Bioconductor package. This workflow explains in detail how to use the 
    recount package and how to integrate it with other Bioconductor packages for
    several analyses that can be carried out with the recount2 resource. In
    particular, we describe how the coverage count matrices were computed in
    recount2 as well as different ways of obtaining public metadata, which can
    facilitate downstream analyses. Step-by-step directions show how to do a
    gene level differential expression analysis, visualize base-level genome
    coverage data, and perform an analyses at multiple feature levels. This
    workflow thus provides further information to understand the data in
    recount2 and a compendium of R code to use the data.
Depends: R (>= 3.4.0)
License: Artistic-2.0
Encoding: UTF-8
LazyData: true
biocViews: WorkflowStep, Coverage, DifferentialExpression, GeneExpression,
    RNASeq, Sequencing, Software, DataImport
VignetteBuilder: knitr
Imports:
    recount,
    GenomicRanges,
    limma,
    edgeR,
    DESeq2,
    regionReport (>= 1.10.2),
    clusterProfiler,
    org.Hs.eg.db,
    gplots,
    derfinder,
    rtracklayer,
    GenomicFeatures,
    bumphunter,
    derfinderPlot,
    devtools,
    rmarkdown,
    knitcitations,
    BiocStyle,
    knitr
NeedsCompilation: no
Workflow: true
URL: https://github.com/LieberInstitute/recountWorkflow
BugReports: https://support.bioconductor.org/t/recountWorkflow/
lcolladotor commented 7 years ago

Here is the tarball that corresponds to https://github.com/LieberInstitute/recountWorkflow/commit/01e6e2a687de3e5c565d20d850750677fef14ec2 (just a few commits before the latest version). Just in case you want to look at the rendered HTML for reviewing the workflow instead of the raw Rmd file.

recountWorkflow_0.99.0.tar.gz

$ R CMD build --keep-empty-dirs --no-resave-data recountWorkflowBioc
Loading required package: colorout
* checking for file ‘recountWorkflowBioc/DESCRIPTION’ ... OK
* preparing ‘recountWorkflow’:
* checking DESCRIPTION meta-information ... OK
* installing the package to build vignettes
* creating vignettes ... OK
* checking for LF line-endings in source and make files
* checking for empty or unneeded directories
* building ‘recountWorkflow_0.99.0.tar.gz’

$ R CMD check --no-vignettes --timings recountWorkflow_0.99.0.tar.gz
Loading required package: colorout
* using log directory ‘/Users/lcollado/Dropbox/Code/recountWorkflow.Rcheck’
* using R version 3.4.1 (2017-06-30)
* using platform: x86_64-apple-darwin15.6.0 (64-bit)
* using session charset: UTF-8
* using option ‘--no-vignettes’
* checking for file ‘recountWorkflow/DESCRIPTION’ ... OK
* this is package ‘recountWorkflow’ version ‘0.99.0’
* package encoding: UTF-8
* checking package namespace information ... OK
* checking package dependencies ... OK
* checking if this is a source package ... OK
* checking if there is a namespace ... OK
* checking for executable files ... OK
* checking for hidden files and directories ... OK
* checking for portable file names ... OK
* checking for sufficient/correct file permissions ... OK
* checking whether package ‘recountWorkflow’ can be installed ... WARNING
Found the following significant warnings:
  Warning: replacing previous import ‘limma::plotMA’ by ‘DESeq2::plotMA’ when loading ‘recountWorkflow’
  Warning: replacing previous import ‘gplots::space’ by ‘rtracklayer::space’ when loading ‘recountWorkflow’
See ‘/Users/lcollado/Dropbox/Code/recountWorkflow.Rcheck/00install.out’ for details.
* checking installed package size ... NOTE
  installed size is  9.8Mb
  sub-directories of 1Mb or more:
    doc   9.8Mb
* checking package directory ... OK
* checking ‘build’ directory ... OK
* checking DESCRIPTION meta-information ... OK
* checking top-level files ... OK
* checking for left-over files ... OK
* checking index information ... OK
* checking package subdirectories ... OK
* checking whether the package can be loaded ... OK
* checking whether the package can be loaded with stated dependencies ... OK
* checking whether the package can be unloaded cleanly ... OK
* checking whether the namespace can be loaded with stated dependencies ... OK
* checking whether the namespace can be unloaded cleanly ... OK
* checking loading without being on the library search path ... OK
* checking installed files from ‘inst/doc’ ... OK
* checking files in ‘vignettes’ ... OK
* checking examples ... NONE
* checking for unstated dependencies in vignettes ... OK
* checking package vignettes in ‘inst/doc’ ... OK
* checking running R code from vignettes ... SKIPPED
* checking re-building of vignette outputs ... SKIPPED
* checking PDF version of manual ... OK
* DONE

Status: 1 WARNING, 1 NOTE
See
  ‘/Users/lcollado/Dropbox/Code/recountWorkflow.Rcheck/00check.log’
for details.

I addressed the warning in my next commit https://github.com/LieberInstitute/recountWorkflow/commit/01e6e2a687de3e5c565d20d850750677fef14ec2.

bioc-issue-bot commented 7 years ago

Your package has been approved for building. Your package is now submitted to our queue.

IMPORTANT: Please read the instructions for setting up a push hook on your repository, or further changes to your repository will NOT trigger a new build.

mtmorgan commented 7 years ago

As a workflow, I think @vobencha should handle this.

bioc-issue-bot commented 7 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/recountWorkflow_buildreport_20170717211059.html

bioc-issue-bot commented 7 years ago

Received a valid push; starting a build. Commits are:

f03a97a v0.99.2 -- require the appropriate dependency vers...

lcolladotor commented 7 years ago

Full commit message for the latest commit.

v0.99.2 -- require the appropriate dependency versions for Bioc 3.6

    * needs bumphunter 1.17.2 or newer in order to include https://github.com/rafalab/bumphunter/commit/8ae30a7daddec1b7e70d789cebb43f195a537a35
    * needs regionReport 1.11.2 or newer (for Bioc 3.6) which is the equivalent of 1.10.2 for Bioc 3.5

The bumphunter dependency should solve the error shown in veracruz1 and tokay1.

Quitting from lines 517-531 (recount-workflow.Rmd) 
Error: processing vignette 'recount-workflow.Rmd' failed with diagnostics:
unused argument (keytype = "ENSEMBL")

malbec1 had another error which seems transient.

Quitting from lines 335-367 (recount-workflow.Rmd) 
Error: processing vignette 'recount-workflow.Rmd' failed with diagnostics:
cannot open the connection
bioc-issue-bot commented 7 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/recountWorkflow_buildreport_20170717215024.html

bioc-issue-bot commented 7 years ago

Received a valid push; starting a build. Commits are:

14c8847 v0.99.3 -- I should have checked the lines of the ...

bioc-issue-bot commented 7 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/recountWorkflow_buildreport_20170717220145.html

bioc-issue-bot commented 7 years ago

Received a valid push; starting a build. Commits are:

1e0343f v0.99.4 -- looks like the spelling of 1 arg change...

bioc-issue-bot commented 7 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR, WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/recountWorkflow_buildreport_20170717222819.html

bioc-issue-bot commented 7 years ago

Received a valid push; starting a build. Commits are:

b4c5731 v0.99.5 -- address some namespace warnings when lo...

bioc-issue-bot commented 7 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/recountWorkflow_buildreport_20170717231354.html

bioc-issue-bot commented 7 years ago

Received a valid push; starting a build. Commits are:

7bd1c10 v0.99.6 -- attempt to resolve the issue on malbec1

bioc-issue-bot commented 7 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/recountWorkflow_buildreport_20170717235724.html

lcolladotor commented 7 years ago

Hi again,

Here is the tarball with the latest version (using Bioc 3.6) in case you want to look at the rendered version of the workflow.

recountWorkflow_0.99.6.tar.gz

Best Leo

$ R CMD build --keep-empty-dirs --no-resave-data recountWorkflowBioc
* checking for file ‘recountWorkflowBioc/DESCRIPTION’ ... OK
* preparing ‘recountWorkflow’:
* checking DESCRIPTION meta-information ... OK
* installing the package to build vignettes
* creating vignettes ...
 OK
* checking for LF line-endings in source and make files and shell scripts
* checking for empty or unneeded directories
* building ‘recountWorkflow_0.99.6.tar.gz’

$ R CMD check --no-vignettes --timings recountWorkflow_0.99.6.tar.gz
* using log directory ‘/Users/lcollado/Dropbox/Code/recountWorkflow.Rcheck’
* using R version 3.4.1 (2017-06-30)
* using platform: x86_64-apple-darwin15.6.0 (64-bit)
* using session charset: UTF-8
* using option ‘--no-vignettes’
* checking for file ‘recountWorkflow/DESCRIPTION’ ... OK
* this is package ‘recountWorkflow’ version ‘0.99.6’
* package encoding: UTF-8
* checking package namespace information ... OK
* checking package dependencies ... OK
* checking if this is a source package ... OK
* checking if there is a namespace ... OK
* checking for executable files ... OK
* checking for hidden files and directories ... OK
* checking for portable file names ... OK
* checking for sufficient/correct file permissions ... OK
* checking whether package ‘recountWorkflow’ can be installed ... OK
* checking installed package size ... NOTE
  installed size is  9.8Mb
  sub-directories of 1Mb or more:
    doc   9.8Mb
* checking package directory ... OK
* checking ‘build’ directory ... OK
* checking DESCRIPTION meta-information ... OK
* checking top-level files ... OK
* checking for left-over files ... OK
* checking index information ... OK
* checking package subdirectories ... OK
* checking whether the package can be loaded ... OK
* checking whether the package can be loaded with stated dependencies ... OK
* checking whether the package can be unloaded cleanly ... OK
* checking whether the namespace can be loaded with stated dependencies ... OK
* checking whether the namespace can be unloaded cleanly ... OK
* checking loading without being on the library search path ... OK
* checking installed files from ‘inst/doc’ ... OK
* checking files in ‘vignettes’ ... OK
* checking examples ... NONE
* checking for unstated dependencies in vignettes ... OK
* checking package vignettes in ‘inst/doc’ ... OK
* checking running R code from vignettes ... SKIPPED
* checking re-building of vignette outputs ... SKIPPED
* checking PDF version of manual ... OK
* DONE

Status: 1 NOTE
See
  ‘/Users/lcollado/Dropbox/Code/recountWorkflow.Rcheck/00check.log’
for details.
lcolladotor commented 7 years ago

If you are wondering why all the packages are in Imports rather than Suggests, it's because I'm following what was done in https://github.com/Bioconductor/Contributions/issues/374. I like the idea of

source("https://bioconductor.org/biocLite.R")
biocLite('recountWorkflow')

installing all the dependencies.

bioc-issue-bot commented 7 years ago

Received a valid push; starting a build. Commits are:

8f16c47 v0.99.7 -- fix a typo on the first sentence

bioc-issue-bot commented 7 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/recountWorkflow_buildreport_20170718204048.html

bioc-issue-bot commented 7 years ago

Received a valid push; starting a build. Commits are:

2ca748d v0.99.8 -- update affiliations

bioc-issue-bot commented 7 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/recountWorkflow_buildreport_20170720162634.html

bioc-issue-bot commented 7 years ago

Received a valid push; starting a build. Commits are:

a8d489a v0.99.9 -- move some packages from imports to sugg...

bioc-issue-bot commented 7 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/recountWorkflow_buildreport_20170721105857.html

bioc-issue-bot commented 7 years ago

Received a valid push; starting a build. Commits are:

8127f0e v0.99.10 -- fix a figure reference

bioc-issue-bot commented 7 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/recountWorkflow_buildreport_20170721113438.html

bioc-issue-bot commented 7 years ago

Received a valid push; starting a build. Commits are:

a5a7c29 v0.99.11 -- match the recent changes made to addre...

bioc-issue-bot commented 7 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/recountWorkflow_buildreport_20170725152923.html

bioc-issue-bot commented 7 years ago

Received a valid push; starting a build. Commits are:

d25b09c v0.99.12 -- require clusterProfiler 3.5.5 now that...

bioc-issue-bot commented 7 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/recountWorkflow_buildreport_20170725154518.html

bioc-issue-bot commented 7 years ago

Received a valid push; starting a build. Commits are:

6f9d11f v0.99.13 -- fix an issue with coverage_matrix()

bioc-issue-bot commented 7 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/recountWorkflow_buildreport_20170729183413.html

bioc-issue-bot commented 7 years ago

Received a valid push; starting a build. Commits are:

2c0fe43 v0.99.14 -- fix a missing white space

bioc-issue-bot commented 7 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/recountWorkflow_buildreport_20170729184613.html

bioc-issue-bot commented 7 years ago

Received a valid push; starting a build. Commits are:

0f3a4ba v0.99.15 -- fix interpretation of DER plots now th...

bioc-issue-bot commented 7 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/recountWorkflow_buildreport_20170730102843.html

bioc-issue-bot commented 7 years ago

Received a valid push; starting a build. Commits are:

8210ba3 v0.99.16 -- fix spelling in some figure legends

bioc-issue-bot commented 7 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/recountWorkflow_buildreport_20170730111554.html

vobencha commented 7 years ago

Hi Leo, I've been out of the office. I'll take a look at this today or tomorrow. Valerie

lcolladotor commented 7 years ago

Thank you Val! The submission process at F1000research is also advancing. Let me know if you have some changes to the workflow in mind so I can update the workflow submitted to F1000research accordingly.

Have a good weekend!

vobencha commented 7 years ago

Hi, Looks good - just a few comments.

1) LazyData Why set LazyData: true? In our experience this has been problematic and makes packages with large data much, much slower to install. recountWorkflow doesn't have data in the package so I'm not sure why you have this directive?

2) The size of the built tarball is large compared to the original package. Ideally workflows are no bigger than the software packages at <=4MB on disk.

biocbuild@malbec1:~/sandbox/unzip$ du -h recountWorkflow_0.99.16.tar.gz 
5.2M    recountWorkflow_0.99.16.tar.gz

I think the embedded graphics are pushing the size over the limit. Have you tried using jpeg or png?

3) Non-resolved figure references Looks like there is a problem with figure(s) 27.

In these plots we can see that some DERs match known exons (Figures ??, ??, ??), some are longer than known exons (Figures ??, ??, ??), and others are exon fragments (Figures ??, ??, ??, ??) which could be due to the cutoff used. Note that Figure ?? could be shorter than a known exon due to a coverage dip.

Back to the issue of space. Is it necessary to include graphs for all 10 regions?

Valerie

bioc-issue-bot commented 7 years ago

Received a valid push; starting a build. Commits are:

4ed8f2b v0.99.17 -- Address Valerie's comments at https://...

lcolladotor commented 7 years ago

Hi Valerie,

Thank you for your comments!

  1. LazyData: sorry, I copied my description from a previous package and forgot to remove that part. 2 and 3. I reduced the number of base level plots from 10 to 1. This should reduce the size.

Best, Leo

bioc-issue-bot commented 7 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/recountWorkflow_buildreport_20170807111802.html

bioc-issue-bot commented 7 years ago

Received a valid push; starting a build. Commits are:

dcf22c6 v0.99.18 -- don't ignore R file

lcolladotor commented 7 years ago

With the recent changes, it's a 2.4 mb tar ball

recountWorkflow_0.99.17.tar.gz

bioc-issue-bot commented 7 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/recountWorkflow_buildreport_20170807114418.html

vobencha commented 7 years ago

Great. Thanks for making the changes. Marking this as approved. Valerie

bioc-issue-bot commented 7 years ago

Your package has been accepted. It will be added to the Bioconductor svn repository and nightly builds. Additional information will be sent to the maintainer email address in the next several days.

Thank you for contributing to Bioconductor!

lcolladotor commented 7 years ago

Awesome, thanks!