Bioconductor / Contributions

Contribute Packages to Bioconductor
134 stars 33 forks source link

recountWorkflow #421

Closed lcolladotor closed 7 years ago

lcolladotor commented 7 years ago

Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor

Note that this package is a workflow and not a software package.

Confirm the following by editing each check box to '[x]'

I am familiar with the essential aspects of Bioconductor software management, including:

For help with submitting your package, please subscribe and post questions to the bioc-devel mailing list.

lcolladotor commented 7 years ago

Hi,

I just pushed version 0.99.20 to https://github.com/LieberInstitute/recountWorkflow that includes the link to https://f1000research.com/articles/6-1558/v1 that was made public today.

Best, Leo

vobencha commented 7 years ago

Sorry this hasn't been added to the repo yet. I think I dropped the ball and forgot to ask @lshep to add this to the workflow repository.

Just fyi, the workflows will stay in svn for the time being. We'll migrate these to git after the dust from the software transition has settled.

lshep commented 7 years ago

Hi @lcolladotor I will look at adding recountWorkflow first thing tomorrow.

lshep commented 7 years ago

You should receive an additional email within the new few days with credentials for updating and maintaining. The recountWorkflow has been added and should appear shortly on the website. Cheers ~Lori

vobencha commented 7 years ago

Thanks Lori!

lcolladotor commented 7 years ago

Thanks Lori!

In the biocbuild emails I see errors like this:

* checking DESCRIPTION meta-information ... OK
* installing the package to build vignettes
      -----------------------------------
* installing *source* package ‘recountWorkflow’ ...
** help
No man pages found in package  ‘recountWorkflow’
*** installing help indices
** building package indices
** installing vignettes
** testing if installed package can be loaded
Error: package or namespace load failed for ‘recountWorkflow’ in loadNamespace(i, c(lib.loc, .libPaths()), versionCheck = vI[[i]]):
 namespace ‘recount’ 1.2.3 is being loaded, but >= 1.3.2 is required
Error: loading failed
Execution halted
ERROR: loading failed

I wrote the description file with Bioc-devel dependencies in mind since that's what was used by the SPB but I can switch it to Bioc-release if necessary.

Best, Leo

lshep commented 7 years ago

sorry about that. It is an issue we are trying to remedy as the workflow currently build on the release version of R. Can you please update to use the release?

lshep commented 7 years ago

Once Martin sends over credentials you will be able to make the changes on our system and it should kick off a new build automatically.

lcolladotor commented 7 years ago

Ok, will do! I'll wait for Martin to send over the credentials.

mtmorgan commented 7 years ago

The repos has been configured so that svn user l.collado-torres has access.

lcolladotor commented 7 years ago

Hi @lshep,

Most of the bioc-devel dependencies can be switched to bioc-release ones. The minor exceptions are:

However, there's a rather large change that I can't port back to bioc-release. That's the bumphunter 1.17.2 requirement. That's related to https://github.com/rafalab/bumphunter/issues/15 that hasn't been changed in the bioc-release branch. I had forgotten about it.

Since switching the workflow builder to bioc-devel is a work in progress, is there an option to add the workflow manually for now?

Otherwise I can ask bumphunter's maintainers to back-port 1.17.2 to the release branch.

A third option would be to stop evaluating the code chunks that depend on bumphunter and include the pre-made images (I use bumphunter's output to eventually make some images). But that doesn't sound right, since bioc-release users wouldn't be able to run the code (aka, there would be a mismatch between the session info and the output).

Best, Leo

lshep commented 7 years ago

@lcolladotor looking into this and will respond soon.

mtmorgan commented 7 years ago

The options are to make recountWorkflow work with current release dependencies, or to delay adding recountWorkflow until immediately after the next release (end of October?). In the 'short' term (several months) can't do anything other that that. What would you like to do?

lcolladotor commented 7 years ago

Hi,

I modified the workflow to work with bioc-release https://github.com/LieberInstitute/recountWorkflow/commit/7971b2c698197597707ce8cd7d0cc4cbc92a72e2 ** and hopefully bumphunter 1.17.2 will be merged to bioc-release (to say 1.16.1) following https://github.com/rafalab/bumphunter/issues/19. At that point or when Bioconductor 3.6 is released, I'll modify back the workflow.

Best, Leo

** And I pushed the changes using svn. I'm just keeping track of things with git separately.