Closed shaileshtripathi closed 7 years ago
@shaileshtripathi Have you contacted the Rsubread authors with a (pull?) request to expose the API you are interested in?
@mtmorgan No, I did not , we used their code available from bioconductor because our approach is related to the "sequence depth analysis" which is related with the random sample of sequence depth and did not find any function in Rsubread which allows to do so, therefore we made some modification inside the code.
@shaileshtripathi you'll have to help me see what you've done by cleaning up the code to include essential functionality and a clear 'diff' between the source files in Rsubread and your own source files. I'm very reluctant for you to simply copy Rsubread's source code, because this means that bug fixes and improvements in Rsubread are not propagated to your package. Rather than 'Have you contacted...' I should have said 'Contact the Rsubread authors with a pull request to expose the API you are interested in'.
@mtmorgan Ok, thanks ya sure I will contact them regarding to use API according to my need.
Received a valid push; starting a build. Commits are:
0a72b9f minor correction 1
Received a valid push; starting a build. Commits are:
e2e0ae2 minor correction 3
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/samExploreR_buildreport_20160803122335.html
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/samExploreR_buildreport_20160803122408.html
We only start builds when the Version
field in the DESCRIPTION
file is incremented. For example, by changing
Version: 0.99.0
to
Version 0.99.1
If you did not intend to start a build, you don't need to
do anything. If you did want to start a build, increment
the Version:
field and try again.
Received a valid push; starting a build. Commits are:
47f3464 minor change 5
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/samExploreR_buildreport_20160804063833.html
Received a valid push; starting a build. Commits are:
ddd9e96 minor change 6
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/samExploreR_buildreport_20160804070824.html
Received a valid push; starting a build. Commits are:
ec40579 minor change 7
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/samExploreR_buildreport_20160804071622.html
Received a valid push; starting a build. Commits are:
33ac5ab minor change 8
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/samExploreR_buildreport_20160804073359.html
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/samExploreR_buildreport_20160818084907.html
Received a valid push; starting a build. Commits are:
087aa3e no win option
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/samExploreR_buildreport_20160818091947.html
It looks like your package is almost ready for review. Can you clean up the missing imports and other notes and warnings from the build report, and subscribe to the Bioconductor 'devel' mailing list to remove the remaining ERROR flag? I will then review this package.
Alternatively, if you'd like to continue to develop your package before review, please remove the web hook and close this issue, develop it on your own system, and when ready open a new issue?
Received a valid push; starting a build. Commits are:
d9cd8ad Minor corrections
Received a valid push; starting a build. Commits are:
6ce9db3 versiton update
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/samExploreR_buildreport_20160822081350.html
Received a valid push; starting a build. Commits are:
95f7fc8 updated version
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/samExploreR_buildreport_20160822095622.html
Received a valid push; starting a build. Commits are:
86104e6 fixing warnings
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/samExploreR_buildreport_20160822103958.html
Received a valid push; starting a build. Commits are:
749eab8 registering native routine
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/samExploreR_buildreport_20160822110410.html
Received a valid push; starting a build. Commits are:
d4d8be3 registering native routine1
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/samExploreR_buildreport_20160822112124.html
Received a valid push; starting a build. Commits are:
7423bc7 changing formatting
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/samExploreR_buildreport_20160822122156.html
It looks like your package still includes Rsubread code rather than using functionality exposed by the Rsubread package or other Bioconductor tools. Also, it looks like there are additional easily corrected errors or warnings. I suggest either that the package be updated to avoid using Rsubread code directly and that the R code be updated to address the minor remaining issues, or that we close the issue and you can resubmit when you've had a chance to revise your package in line with these requirements.
From what I understand, you have been in touch with the Rsubread author and they have given you guidance on how to avoid using Rsubread C code directly. Please let me know promptly how you would like to proceed.
We only start builds when the Version
field in the DESCRIPTION
file is incremented. For example, by changing
Version: 0.99.0
to
Version 0.99.1
If you did not intend to start a build, you don't need to
do anything. If you did want to start a build, increment
the Version:
field and try again.
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/samExploreR_buildreport_20160913095904.html
We only start builds when the Version
field in the DESCRIPTION
file is incremented. For example, by changing
Version: 0.99.0
to
Version 0.99.1
If you did not intend to start a build, you don't need to
do anything. If you did want to start a build, increment
the Version:
field and try again.
We only start builds when the Version
field in the DESCRIPTION
file is incremented. For example, by changing
Version: 0.99.0
to
Version 0.99.1
If you did not intend to start a build, you don't need to
do anything. If you did want to start a build, increment
the Version:
field and try again.
Received a valid push; starting a build. Commits are:
de5cdd4 new data added
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/samExploreR_buildreport_20160913100549.html
Received a valid push; starting a build. Commits are:
b72dc7a new changes added
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/samExploreR_buildreport_20160913101708.html
Received a valid push; starting a build. Commits are:
43589c7 version updated
Dear Package contributor,
This is the automated single package builder at bioconductor.org.
Your package has been built on Linux, Mac, and Windows.
On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.
Please see the following build report for more details:
http://bioconductor.org/spb_reports/samExploreR_buildreport_20160914042211.html
Hi Martin,
We have removed the dependencies of samExploreR on Rsubread I updated it long ago but it is not accepted yet, can you please take a look on that.
Best, Shailesh
On Tue, Aug 2, 2016 at 1:36 PM, Martin Morgan notifications@github.com wrote:
@shaileshtripathi https://github.com/shaileshtripathi you'll have to help me see what you've done by cleaning up the code to include essential functionality and a clear 'diff' between the source files in Rsubread and your own source files. I'm very reluctant for you to simply copy Rsubread's source code, because this means that bug fixes and improvements in Rsubread are not propagated to your package. Rather than 'Have you contacted...' I should have said 'Contact the Rsubread authors with a pull request to expose the API you are interested in'.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Bioconductor/Contributions/issues/62#issuecomment-236890798, or mute the thread https://github.com/notifications/unsubscribe-auth/ATkbzHL81-9w1axpv7TTTb9SOx5FokURks5qbznGgaJpZM4JO7QV .
I asked for clarification on the status of your package on August 23, and when you did not respond declined the package on September 7. I take it you would now like your package to be considered for review. I will re-open the issue, and will proceed with a review when the remaining warnings and errors are addressed; see the most recent build report.
Received a valid push; starting a build. Commits are:
d99cb47 version update
Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor
I am familiar with the essential aspects of Bioconductor software management, including:
For help with submitting your package, please subscribe and post questions to the bioc-devel mailing list.