BiologicalRecordsCentre / ABLE

Assessing ButterfLies in Europe project repository
2 stars 3 forks source link

Verification page: not allowing editing other taxa apart from butterflies #457

Closed CrisSevilleja closed 1 year ago

CrisSevilleja commented 2 years ago

On the verification page of ebms https://butterfly-monitoring.net/verification, it is not possible to edit a record adding a moth or dragonfly species. The searching bar is only completing for butterfly species.

One example for a Lithuanian verifier with the permission to edit records for butterflies, dragonflies and moths not able to include the genus Xanthorhoe (moth), only butterfly species appearing (Nymphalis xanthomelas). image

I tried with my account, I am a verifier for all records and I cannot add moth species (e.g. Zygaena genus) 2022-07-07_10h28_34 2022-07-07_10h28_20

Could someone have a look at this? @DavidRoy @Gary-van-Breda or @johnvanbreda Thank you

DavidRoy commented 2 years ago

@JimBacon can you add this to your (long!) list of tasks

JimBacon commented 2 years ago

Hi @CrisSevilleja

I think you are reporting two issues here, although they may have similar symptoms.

  1. On the Verification page, https://butterfly-monitoring.net/verification, when attempting to redetermine a record, a Lithuanian verifier was unable to select a moth species.

This may relate to permissions of the verifier since it is possible for you to do this. Can you email me their name so that I can try masquerading as them? Screenshot when masquerading as you. image

  1. On the Edit a Record page, https://butterfly-monitoring.net/edit-generic-record, you cannot edit a record and select a moth species.

That is expected behaviour, based upon the configuration, see screenshot. image The form allows a second species list to be added, such as the moth list, but not a third like dragonflies.

I don't see a form on the website where a person might enter a dragonfly record. Has the app development overtaken the website development?

JimBacon commented 2 years ago

Hi @CrisSevilleja

I've looked in to the issue of re-determining species on the verification page. The situation is this:

With the 'Search all speci' option not ticked

You can not change an observation from one taxonomic group to another.

The 'Search all speci' checkbox has the following comment

This record was identified against a restricted list of taxa. Check this box if you want to redetermine to a taxon selected from the unrestricted full list available.

If you tick the box it causes the search to use the list with ID = 254, entitled EBMS Butterflies - unused. This is clearly something old that is no longer correct.

What is the desired behaviour?

CrisSevilleja commented 2 years ago

Hi @JimBacon

Thanks for explaining everything. Regarding the desired behaviour, I think the second option makes sense. I don't think or it shouldn't be that we need to redetermine species across species groups, we expected to redetermine within a species group. @DavidRoy do you agree on this?

DavidRoy commented 1 year ago

@JimBacon happy to discuss options around this. Given the related issue #584, we may end up requiring editing/redetermining names across species lists and therefore need a European master list with child lists - hard to see us avoiding this?

JimBacon commented 1 year ago

To summarise the above discussion:

Investigating, I find:

JimBacon commented 1 year ago

A fix has now been deployed for this issue. Note, there is no change in the redetermination function. All that has happened is that the checkbox to select "the unrestricted full list" has been hidden because no such list exists for EBMS. You can redetermine within a species group but not from one species group to another.

@CrisSevilleja please review and close if satisfactory.

CrisSevilleja commented 1 year ago

@JimBacon thanks for fixing this. The verification page allows to redetermine for moths and dragonflies species.

One small detail is that the loading time is a bit long. When typing the species name, the suggested list takes a bit to be loaded, a few seconds. If that can be checked the best, but not a high priority. I tried with Libellula or Sympetrum genus of dragonflies.

For now, I close this issue.