search

BiologicalRecordsCentre / ABLE

Assessing ButterfLies in Europe project repository
2 stars 3 forks source link

Improve EBMS/UKBMS file structures to allow full iForm updates #622

Open andrewvanbreda opened 1 year ago

andrewvanbreda commented 1 year ago

Hi @Gary-van-Breda

I will also email you about the following so it doesn't get lost amongst all the other Github notifications.

As discussed on the phone, here are the details of the work I have been doing regarding making EBMS/UKBMS work with future iForm updates (which may include automatic iForm updates). I have not been able to fully iForm update the live sites so far, so even the PHP 8 compatibility on them is a bit sketchy and throwing invisible warnings into the logs still.

The URLs of the multidev environments I have been doing the work on are

https://avb-iform-brc-ebms.pantheonsite.io/

https://avb-iform-brc-ukbms.pantheonsite.io/

As noted on the phone, the main problem I have remaining relates to the report_helper.

A few notes

  1. As discussed, I didn't attach all my notes relating to this. Let me know if you change your mind need to read through them and I will write them up.

  2. The iForm/clients_helpers/media/indicia_features has been updated on both the multdev sites from Indicia-Team Master. Then I made changes which have been committed to the Pantheon multidev sites and also committed into indicia-team Develop ready for future release if agreed upon. Those changes that have ended up in Develop have also been applied to the multidev sites so we can see if they work, so don't do further iForm updates from Master Indicia-Team on those sites as we would lose the changes.

  3. As noted in our phone conversation, remaining concern I have regards the report_helper. This seems to vary between UKBMS/EBMS/indicia-team client_helpers and I think it would currently break if overwritten by the indicia-team file. I had similar situations with other files I was able to deal with, but this file being so central to indicia has left me with a difficulty..

  4. As mentioned on phone, I have recently done some work on EBMS relating to Japan.

The change was originally made to report_calendar_grid on master/live. However having reviewed these changes, I will not commit these to Indicia-Team develop. The reason is (I realised afterwards) that these changes would break for other projects as the check to see if the ebms module exists fails on other projects (just before the definition of the taxon_column_overrides), at least on my own machine, although seem ok on EBMS live. I think this is because of the position of that line in the code.....I think anyway.

On the avb-iform site, this code has been moved into a new file anyway "ebms_report_calendar_summary_2.php" which will not be used on other projects, so was able to remove that line. If you need to search for the code for this change in a file, most of the code is in a function called forceCommonNameLanguageOptionIfNeeded, I can't remember off the top of my head if there were also changes in report_helper, but if you are examining that file anyway I guess you'll see.

  1. Note that although I completed my changes (minus the report_helper), I didn't test them yet, most of the pages have just been checked they roughly look like they are loading.

Let me know what you think about the report_helper and any other useful thoughts.

Thanks

Andrew

andrewvanbreda commented 1 year ago

Hi @BirenRathod

I have given both the reworked (avb-iform) UKBMS and EBMS sites a test. These are the reworked sites that should allow for iForm updating going forward. Gary still has to work on the report_helper, but these tests give us an idea of how close we are to being able to get these live.

I have attached a file detailing test results for future reference. There is no need to look through all those notes, a summary is as follows:

UKBMS Almost exactly performs like live. Some tests such as assigning sites to users could not be performed (as didn't want to intefere with live data) Some minor test failures.

EBMS Still did reasonably well in tests. Some data entry forms were not tested, again did not want to intefere with live data. The main problem I encountered was quite a few pages did not work because ElasticSearch was throwing errors (I suspect this is perhaps this is just because it won't work with my live site rather than code issue, but need to confirm this is the problem?)

There are a couple of issues I found that affect the current live too, I can fix these when I review my notes before we go live with the changes.

Testing Detail.txt