BiologicalRecordsCentre / ABLE

Assessing ButterfLies in Europe project repository
2 stars 3 forks source link

End time of 15min counts incorrect: end time sets when survey submited for one user #687

Open CrisSevilleja opened 1 month ago

CrisSevilleja commented 1 month ago

Describe the issue

A user (user ID 376708) of the app had reported a problem with the incorrect end time of his records (15min counts) on the website (see screenshot 1). At first, I thought it was related to the UK time of the server, but the difference is so big that it cannot be.

It looks like the end time is not created in relation to the end of the survey, but rather the time of data submission.

This has always happened with this recorder as you can see in the submission. I confirm that the user clicked the "Finish" button at the end of the survey, which is the button that sets the end time, and later submitted the surveys at home after checking the images.

15min count samples with this error: ID25426480, ID25235815 (screenshots)

I don't know if the error comes from the app or the website, the times cannot be checked on the app after submission. @kazlauskis @andrewvanbreda

Expected behaviour

Store the End Time of the 15min counts and visualize it correctly on the website https://butterfly-monitoring.net/mydata/samples

To Reproduce

  1. Do a 15min count
  2. Click on Finish
  3. Click on Upload after checking the survey
  4. go to My samples page on eBMS website https://butterfly-monitoring.net/mydata/samples and see Start and End time of the 15min count correct as recorded

App Version

v1.26.3 (350)

Device

iPhone 11 version IOS 17.3.1.

When did this happen

since this user is registering, this year

Screenshots

1 error on 15min count times user 376708 ID25426480 ID25235815

Additional context

No response

kazlauskis commented 1 month ago

@CrisSevilleja, thanks for filling in the details. This is not a website-related issue, as it is a custom attribute that the website doesn't modify. We set the survey time in the app only in one place, and that is when users tap the "Finish" button. Are you sure the user finishes the survey after 15 minutes and not when they upload it? Unfinished surveys have a 'draft' status, so that would be easy to check.

A test they could run:

  1. create a new survey
  2. (take a screenshot, so I can see the time)
  3. wait for 15 minutes
  4. (take a screenshot)
  5. press Finish
  6. (take a screenshot)
  7. wait for another 15 minutes
  8. press Upload
  9. (take a screenshot)
  10. send me the sceenshots
CrisSevilleja commented 1 month ago

Hi Karolis, thanks for your reply. I asked him directly about pressing the Finish button, but I only had an email conversation about it... I will ask him to do the test and send me all the screenshots. Anyway, it is not possible to submit the surveys without clicking the Finish button, is it?

kazlauskis commented 1 month ago

You're right. Users need to press the Finish button before pressing Upload. But they can start a survey, wait for 15 minutes to pass, go home, and then press Finish+Upload later in the evening, so the end time would be that of when it was pressed.

CrisSevilleja commented 1 month ago

indeed, that's the point to discover, if they press finish just before submitting at home or correctly on the field. I already asked, let's see what we get. thanks!

CrisSevilleja commented 4 weeks ago

Hi @kazlauskis the user replied with the screenshots. Apparently, he is doing correctly the submission of the 15min count, by clicking the Finish button. I mentioned again the importance of clicking the Finish button at the end of the count and not when submitting and he said he did it correctly.

The test you asked for:

  1. create a new survey 1
  2. wait for 15 minutes 02
  3. press Finish 03
  4. wait for another 15 minutes & press Upload (he submitted the survey) 04

Checking his account (user ID 376708), the surveys submitted recently are not on the website, neither the test nor the ones from the 30 of May... There is something on the connection between the website and the app as Chris mentioned #686 5

I hope this was useful.

kazlauskis commented 3 weeks ago

@CrisSevilleja thanks, the test shows the app works OK in this example. I can see the record in the app and on the website with the finish time of 17:58. I'll keep an eye on this, but at the moment, I don't see why records could have such finish times, so most likely, users press Finish when uploading.

Screenshot 2024-06-10 at 12 09 43

Just stepping back for a moment, please remind me why we must capture the end time. At the moment, it just sets a timestamp, that's all. The GPS isn't affected as it is stopped when the 15 minutes run out, and the app still allows adding species beyond pressing the Finish, so it is not that we know when the user has actually stopped surveying.

CrisSevilleja commented 3 weeks ago

Thank you @kazlauskis, I will communicate this to the user, It's a bit strange but the most probable case is he is not pressing well the button after finishing the survey.

We are capturing the End Time because it is not always 15min in case the recorder pauses the survey. Then we can filter the surveys with longer or shorter times than 15min. I think that is the case, maybe @chrisvanswaay or @DavidRoy can corroborate it. However, as you mentioned, it depends on the correct behaviour of the recorder pressing the Finish button at the end of the survey and we cannot be sure they pressed it at the correct time. Maybe we can place a short note under the end time mentioning to press the End time after finishing the survey...