BiologicalRecordsCentre / ABLE

Assessing ButterfLies in Europe project repository
2 stars 3 forks source link

Adjustment required for 250W Mercury Vapour lamp type term (E40 not E27) #700

Open andrewvanbreda opened 5 months ago

andrewvanbreda commented 5 months ago

As noted by @larspett in issue #664 There appears to be an issue with the existing E27 250W Mercury Vapour lamp type term hierarchy,

From Lars "the 250W Mercury Vapour isn’t E27, that socket is E40.".

I note this seems to be controlled by this hierarchical termlist, and I note the parent ID of different terms can't be switched in the Warehouse UI.

https://warehouse1.indicia.org.uk/index.php/termlist/edit/987?tab=terms

Is this something you can pick up @JimBacon with a DB tweak?

Thanks

Andy

andrewvanbreda commented 5 months ago

Note there does appear to be a "Parent term" field on the Warehouse terms, but I tested changing that on a termlist on my own machine, and the change is not saved so I don't think terms can be switched around in that way.

andrewvanbreda commented 5 months ago

Hi @larspett Can I just double check something. It is just the 250W Mercury Vapour that needs changing?, not everything that was E27? I am just double checking because the fix is very different if it were everything, I am assuming it is just the 250W as you noted.

larspett commented 5 months ago

Yeah the socket is E40, everything else is as before

andrewvanbreda commented 5 months ago

@larspett Thank you for the confirmation.

JimBacon commented 5 months ago

I'm just using Google to try to confirm the sizes as it seemed unlikely that the 500W would be E27 if the 250W is E40. If these are the lamps ML family made by Philips then it seems they do not make a 250W lamp in this family. It does confirm the 500W is E40.

However, there is a 250W/E40 lamp in the HPL family

The options we currently have are

My search suggests this should be

Could this be consistent with your experience @larspett? Another possibility is that a ML/250W was made previously although there is actually evidence of this having existed with an E27 fitting. (Or, indeed, with both!)

It may be the case that we have to add an E40 category with ML/500W, HPL/250W and HPL/400W while retaining the existing E27 options.

larspett commented 5 months ago

Hi the latter seems fine, haven’t ever seen an E27 250W, forgot about the 400W

JimBacon commented 5 months ago

I've added new options for the 3 lamps available in E40 fittings.

I marked the corresponding options for lamps with E27 fittings as 'not for data entry', in the hope that this will prevent them being offered as options for new records while not affecting existing records. That doesn't seem to have worked which is a separate issue.

I have not modified records which use the E27 options. That is still an option but, from the point of view of a moth, I don't think the electrical fitting will be particularly important.

larspett commented 5 months ago

Thanks! If I update sites that use that lamp, will older records inherit that site information? (Not much worried about the sockets but rather that the relational database is happy & working)

JimBacon commented 5 months ago

Moth records are linked to site-trap-lamp records so, if you change a site-trap-lamp to use a different lamp, older moth records, when queried, will show the revised lamp details.

If you were to change a lamp from 250W to 400W then a new site-trap-lamp record needs to be created so that older moth records continue to link to the 250W lamp while new ones link to the 400W lamp. (I feel like the website should issue a warning to users about this.)

Updating the settings for the website will not propagate to the app if I read the comment from @kazlauskis correctly.

larspett commented 5 months ago

Hmm, unfortunate that the website still appears to live a parallel life relative to the app, functionality ought to converge gradually