search

Bitcoin-Wildlife-Sanctuary / bitcoin-circle-stark

Building blocks of a Circle STARK verifier in Bitcoin script
https://docs.btcwild.life
MIT License
123 stars 23 forks source link

Composition polynomial implementation #29

Closed victorkstarkware closed 4 months ago

victorkstarkware commented 4 months ago

Implemented the (Fibonacci) composition polynomial inside the Fibonacci module. It doesn't have all the abstractions as in Stwo because we are not trying to build something general.

Note: Because in Stwo step_constraint_eval_quotient_by_mask() and boundary_constraint_eval_quotient_by_mask(), are PRIVATE, their code had to be copied to fibonacci/mod.rs in 'FibonacciComposition'.

How should we deal with this?

PS added "itertools" dependency.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 91.42857% with 3 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/fibonacci/bitcoin_script.rs 100.00% <100.00%> (ø)
src/oods/bitcoin_script.rs 100.00% <ø> (ø)
src/fibonacci/mod.rs 85.00% <85.00%> (ø)

... and 9 files with indirect coverage changes