Improve Merkle Tree and Fibonacci scripts

Bitcoin-Wildlife-Sanctuary / bitcoin-circle-stark

Building blocks of a Circle STARK verifier in Bitcoin script

https://docs.btcwild.life

MIT License

124 stars 23 forks source link

Closed dikel closed 3 months ago

dikel commented 3 months ago

Improves the size of the Fibonacci and Merkle Tree scripts by removing the redundant opcode sequence of OP_TOALTSTACK OP_FROMALTSTACK.

codecov[bot] commented 3 months ago

All modified and coverable lines are covered by tests :white_check_mark:

Files	Coverage Δ
src/fibonacci/bitcoin_script/fold.rs	`100.00% <100.00%> (ø)`
src/merkle_tree/bitcoin_script.rs	`100.00% <100.00%> (ø)`
src/utils/bitcoin_script.rs	`91.56% <100.00%> (+1.28%)`	:arrow_up:
src/utils/mod.rs	`100.00% <ø> (ø)`

weikengchen commented 3 months ago

Let me think about the best ways to name the functions... You are right!

weikengchen commented 3 months ago

@all-contributors please add @dikel for code

allcontributors[bot] commented 3 months ago

@weikengchen

I've put up a pull request to add @dikel! :tada: