BlueBrain / libsonata

A python and C++ interface to the SONATA format
https://libsonata.readthedocs.io/en/stable/
GNU Lesser General Public License v3.0
12 stars 12 forks source link

Report.file_name returns full path #221

Closed joni-herttuainen closed 2 years ago

joni-herttuainen commented 2 years ago

libsonata._libsonata.Report.file_name seems to return the file_name as"$CIRCUIT_DIR/file_name". I think this should just be the file name (e.g., "soma" or "soma.h5" with the added format).

mgeplf commented 2 years ago

Quick inspection it's a path that gets concretized to an absolute one, relative to the location of the simulation_config.json: do you have the simulation_config.json in the same directory as the circuit_config.json

joni-herttuainen commented 2 years ago

Ah, yes, you're correct. My bad: the description should say base_path/file_name where base path is the directory of the simulation.

mgeplf commented 2 years ago

nice catch

it appears that the correct behavior from https://github.com/AllenInstitute/sonata/blob/master/docs/SONATA_DEVELOPER_GUIDE.md Reports are always written to the output directory given in the output configuration block

joni-herttuainen commented 2 years ago

Good finding! I seem to always forget such document exists.

mgeplf commented 2 years ago

fixed in #222