Fix #226 for empty selections.

BlueBrain / libsonata

A python and C++ interface to the SONATA format

https://libsonata.readthedocs.io/en/stable/

GNU Lesser General Public License v3.0

12 stars 12 forks source link

Fix #226 for empty selections. #232

Closed matz-e closed 2 years ago

matz-e commented 2 years ago

Part of our software uses empty selections to extract the datatype from the returned Numpy arrays. But with #226, HDF5 does not like the created empty HDF5 slabs, so return directly when nothing is requested.

GianlucaFicarelli commented 2 years ago

We could add also a test with empty selections in test_source_nodes and test_target_nodes as in https://github.com/BlueBrain/libsonata/pull/233 (I opened that PR because I didn't see this one)

WeinaJi commented 2 years ago

It seems that the new tag also breaks the synapse reading in our simulation CIs. https://bbpgitlab.epfl.ch/hpc/sim/blueconfigs/-/jobs/384346 We need this fix asap.