search

BlueBrain / libsonata

A python and C++ interface to the SONATA format
https://libsonata.readthedocs.io/en/stable/
GNU Lesser General Public License v3.0
12 stars 12 forks source link

switch to having `connection_overrides` being a list #263

Closed mgeplf closed 1 year ago

mgeplf commented 1 year ago
mgeplf commented 1 year ago

fixes #262

mgeplf commented 1 year ago

@NadirRoGue not sure if you use the simulation config connection_overrides, but this is another API breaking, and just wanted to give you a heads up. (Feel free to review, as well, if you have time)

NadirRoGue commented 1 year ago

Hey, thanks for the heads up!. We are not using this parameter, so we are safe. And LGTM

WeinaJi commented 1 year ago

Looks all good to me. Thanks for making it.

@jorblancoa @ferdonline , are you also fine with the API changes? We will need to adapt in neurodamus. I don't think that we can make neurodamus backward compatible with the connection dict type, so we need to change to array in all the sonata config files in our CI tests..

WeinaJi commented 1 year ago

Thank @mgeplf for making the changes. Could you please ping me when you deploy a new tag? I will prepare to merge the changes on the neurodamus side.

mgeplf commented 1 year ago

Thank @mgeplf for making the changes. Could you please ping me when you deploy a new tag? I will prepare to merge the changes on the neurodamus side.

Sure, I was thinking of doing it today, does that work for you?

WeinaJi commented 1 year ago

Thank @mgeplf for making the changes. Could you please ping me when you deploy a new tag? I will prepare to merge the changes on the neurodamus side.

Sure, I was thinking of doing it today, does that work for you?

Yes, that is good for me.

mgeplf commented 1 year ago

Yes, that is good for me.

I tagged and released it yesterday. I won't make the spack package update, so you can coordinate that when neurodamus is ready.