Possibly avoid `using` in public headers.

BlueBrain / libsonata

A python and C++ interface to the SONATA format

https://libsonata.readthedocs.io/en/stable/

GNU Lesser General Public License v3.0

11 stars 12 forks source link

Possibly avoid `using` in public headers. #301

Closed 1uc closed 9 months ago

1uc commented 10 months ago

We define H5 to be an alias for the namespace HighFive here: https://github.com/BlueBrain/libsonata/blob/7a3983a4ac89535550075feafd5338a1693a1f5f/include/bbp/sonata/report_reader.h#L13

While libsonata hasn't commited to a stable API yet, IMO it's worth considering removing the line. Especially, since H5 is mildly encroaching on HDF5 names.

mgeplf commented 9 months ago

100% agree; I'll make a PR.

mgeplf commented 9 months ago

Fixed in #316