search

BlueBrain / libsonata

A python and C++ interface to the SONATA format
https://libsonata.readthedocs.io/en/stable/
GNU Lesser General Public License v3.0
11 stars 12 forks source link

Refactor _readSelection. #315

Closed 1uc closed 9 months ago

1uc commented 9 months ago

This commit refactors _readSelection in such a manner that:

  1. Canonical selections don't require post-read shuffling.
  2. The reading of the dataset is moved to a separate function.

As a consequence, there's no need for an optimization for std::string, since those only matters when reading from the "@library", which should only happen indirectly. Hence, we free to ensure that those are always canonical.

1uc commented 9 months ago

This is a preparatory PR for https://github.com/BlueBrain/libsonata/pull/307