search

BlueBrain / libsonata

A python and C++ interface to the SONATA format
https://libsonata.readthedocs.io/en/stable/
GNU Lesser General Public License v3.0
11 stars 12 forks source link

Absolute/RelativeShotNoise input: replace amp_cv with relative_skew #361

Closed WeinaJi closed 1 month ago

WeinaJi commented 1 month ago

Sonata specs: https://github.com/BlueBrain/sonata-extension/pull/59

WeinaJi commented 1 month ago

Thanks. This change looks good to the Cells team.

@darshanmandge Thank you for the review. I have also updated the simulation parser in the previous two PRs that I forgot to inform you. https://github.com/BlueBrain/libsonata/pull/359 https://github.com/BlueBrain/libsonata/pull/358 Once a new tag is created and deployed on bb5, you will probably see the difference on your side.

darshanmandge commented 1 month ago

@WeinaJi Thanks for informing about these changes! We will update bluecellulab accordingly.

ilkilic commented 1 month ago

I can confirm that https://github.com/BlueBrain/libsonata/pull/359 https://github.com/BlueBrain/libsonata/pull/358 do not affect bluecellulab