search

BlueBrain / spack-packages

Repository of spack external packages
7 stars 6 forks source link

Possible reproducibility problem in neuron package #60

Closed wvangeit closed 6 years ago

wvangeit commented 6 years ago

I guess this could change results ?

https://github.com/pramodskumbhar/spack-packages/blob/develop/packages/neuron/package.py#L77

Maybe you can make a coreneuron variant ?

pramodskumbhar commented 6 years ago

Yes. When I created PR to official Spack repo I removed that. I will create coreneuron variant.

pramodskumbhar commented 6 years ago

@wvangeit : I added coreneuron variant which is off by default. Note that when we add new variants or change version names then checksum/hash of package changes. So when you pull, remove old versions.