search

BobAtchley / weewx-ws6in1

weewx driver for the 6 in 1 PC weather station clones
GNU General Public License v3.0
5 stars 6 forks source link

Checking absent wind direction entries crashes the utility #1

Closed ArendPWS closed 4 years ago

ArendPWS commented 4 years ago

https://github.com/BobAtchley/weewx-ws6in1/blob/da0e783105a895bf0c589172e073ce7181286059/bin/user/csv_ws6in1#L143

When testing this new utility it crashed on absent wind direction entries. Expanding this code to:

if my_str == "--" or my_str == "---":

fixed it.

This check for absent wind direction entries is also lacking in WS6in1.py.

BobAtchley commented 4 years ago

I have released version 0.8 of WS6in1 which includes the suggested fix. This behaviour has not been seen from my weather station, but its early days and if this makes the WS6in1 more stable then we all benefit. Thanks for raising the issue

ArendPWS commented 4 years ago

Hello Bob,

I suspect behaviour is related to the way the console is configured. If one chooses to display numerical wind directions there might be no problem. I have mine configured to display cardinals and it only crashed on missing/faulty entries,

Op di 23 jun. 2020 om 22:49 schreef BobAtchley notifications@github.com:

Closed #1 https://github.com/BobAtchley/weewx-ws6in1/issues/1.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/BobAtchley/weewx-ws6in1/issues/1#event-3474745759, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQBE2AZ3HAOOZVAXDQSQHDLRYEINTANCNFSM4OEKP25Q .