search

BookOps-CAT / NightShift

Copy cataloging bot
MIT License
7 stars 1 forks source link

Worldcat init & logging init #5

Closed klinga closed 2 years ago

klinga commented 2 years ago

Hi Mike, This is a bit messy and larger than usual pull. Sorry about that. I've been tweaking constantly things that has already been reviewed. bot.py and manager.py are mostly a placeholders at this point as I was trying to figure how how the app should work. Please excuse commented out code, although maybe this will give you clues how my thinking goes.

Per your advise I began creation of some basic structure:

I've tried to use some typing, but I did not apply it consistently across the board yet. I will clean it up in the next pull.

mwbenowitz commented 2 years ago

Also on the coveralls failure, I don't think a 99.7% coverage is really something that needs to be addressed haha

klinga commented 2 years ago

@mwbenowitz If that would not be a trouble would you be able to review my changes? The code differs quite a bit and maybe you will spot some better solutions. TIA!