Boonstra / Slideshow

17 stars 18 forks source link

Always chooses the first slideshow in the select. #12

Open lofgrenfredrik opened 8 years ago

lofgrenfredrik commented 8 years ago

This plugin is incompatible with ACF.

When adding a upload field ACF outputs a hidden dummy editor at the bottom of the edit page for a post (I do not know why).

The line here looks for an element with ID insertSlideshowShortcodeSlideshowSelect. But because ACF outputs the dummy editor we end up with two elements with the same ID. The modal (a.k.a. ThickBox) always ends up at the end of the document, meaning that the code always selects the value of the select box in the dummy editor. I hope you can follow :)

Changing the line to something more contextual like: slideshowID = parseInt($(event.target).closest('table').find('select').val(), 10), would make this plugin work again properly. This guards against any duplicates created by other plugins and assures that the modal will always use the value of the select next to the insert-button.