search

Boonstra / Slideshow

17 stars 18 forks source link

Different session ID on settings and actual element #7

Closed CrocoDillon closed 9 years ago

CrocoDillon commented 10 years ago

I have an issue where the session ID on settings is 0 (var SlideshowPluginSettings_0 = { ... }), but on the actual element it's 1 (data-session-id="1"). This is with only one Slideshow on the page. Result is a JS error (because this.settings is undefined).

I worked around it by removing the sessionCounter increment with the limitation that there can only be one Slideshow per page now.

Any idea where this issue can come from? (Oh yeah, it's version 2.2.21)

Boonstra commented 9 years ago

I'm sorry for my late response.

Perhaps the issue is caused by how the assignment of $sessionID and the increment of self::$sessionCounter are on the same line. I've separated these actions in version 2.2.22, hopefully this will fix your issue without you having to work around it.

CrocoDillon commented 9 years ago

Thanks for the reply, better late than never :wink: :+1: