EDIT ME Include the app name and if it is a Package app or an Install based App

BITIW commented 1 year ago

What is the name of the app?

Playit.gg

(Optional) Where is the app hosted?

Playit.gg

About the app

playit.gg is a networking service that make it possible to host game servers at home that anyone across the world can join. We do this through our custom tunneling software. When you launch the playit program, the program will connect to our Anycast Network and assign you a static IP and port. You can then share your static IP and port with friends. When they connect, their connection information will go to the nearest tunnel server and be tunneled to the playit program running on your computer. By tunneling the connection, your friend is able to connect to the server running within your network.

Upload file or Add PR Link

edit: gman re-upload as a zip Playit.zip

Confirmations

[X] I have confirmed that this app is legal and not piracy.
[X] I have confirmed that this app has never been discussed in https://github.com/Botspot/pi-apps/issues and https://github.com/Botspot/pi-apps/pulls, and it is not in the Pi-Apps app list.
[X] I have confirmed that this app can run on Raspberry Pi.

github-actions[bot] commented 1 year ago

Hello there 👋 Thanks for submitting your first issue to the Pi-Apps project! We'll try to get back to you as soon as possible. In the meantime, we encourage you join our Discord server, where you can ask any questions you might have.

Please respond as soon as possible if a Pi-Apps maintainer requests more information from you. Stale issues will be closed after a lengthy period of time with no response.

Botspot commented 1 year ago

Hello, thank you for taking the time to request this to be added to Pi-Apps. First, I recommend you tweak your github issue to get the title right. Of course I could do it, but it would get annoying if I did that for everyone.

I recommend reading through our app submission documentation. It includes some script-writing guidelines and specific allowed ways to install apt packages. In your case, you should be using our install_packages function, and you should be removing the apt repo and GPG key on uninstall. You also missed some || error lines. Also your description should include usage information. Consider it a short manpage or --help menu. Users should be able to look at your description and get a good understanding on how and when to use the program, not a bunch of corporate-speak about 'our custom tunneling software'. Also, I can't tell if this is open source or not. You should probably make that clear. And you should make clear how this tunneling software is better than the competition. (And there is a lot of competition.)

theofficialgman commented 1 year ago

also don't lie about the compressed folder format. what you uploaded is not a zip file. it is a 7z file.

Playit.gg.zip: 7-zip archive data, version 0.4

BITIW commented 1 year ago

I’m sorry about that. My raspbian compressed into 7z, and i saw that needed zip, so i renamed it (it didn’t broke archive)

Пт, 18 авг. 2023 г. в 22:39, theofficialgman @.***>:

also don't lie about the compressed folder format. what you uploaded is not a zip file. it is a 7z file.

Playit.gg.zip: 7-zip archive data, version 0.4

— Reply to this email directly, view it on GitHub https://github.com/Botspot/pi-apps/issues/2430#issuecomment-1684359547, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARGJKSSINCTIGENT5NKIKY3XV7AFPANCNFSM6AAAAAA3V2YAKY . You are receiving this because you authored the thread.Message ID: @.***>

theofficialgman commented 1 year ago

I’m sorry about that. My raspbian compressed into 7z, and i saw that needed zip, so i renamed it (it didn’t broke archive)

thats where you are wrong. 7z and zip are totally different archival formats and are not compatible with one another. by renaming it to an incompatible format you did break the archive. it cannot be extracted by the zip cli tool.

github-actions[bot] commented 1 year ago

A zipfile was found in the body of your issue. The sha1sum of the zip was: e4ffc4a3b4dafe135619a346476ac5e6116d7cfb The contents can be previewed below:

Playit.gg/credits

playit.gg

Playit.gg/install

#!/bin/bash

#Be sure to use the "error" function - it will display a message if a command fails to run. Example below:

curl -SsL https://playit-cloud.github.io/ppa/key.gpg | sudo apt-key add - || error 'Faild to install keys!'
sudo curl -SsL -o /etc/apt/sources.list.d/playit-cloud.list https://playit-cloud.github.io/ppa/playit-cloud.list
sudo apt update
sudo apt install playit

Playit.gg/website

https://playit.gg/

Playit.gg/description

To run playit it, simply run in console "playit"

playit.gg is a networking service that make it possible to host game servers at home that anyone across the world can join. We do this through our custom tunneling software. When you launch the playit program, the program will connect to our Anycast Network and assign you a static IP and port. You can then share your static IP and port with friends. When they connect, their connection information will go to the nearest tunnel server and be tunneled to the playit program running on your computer. By tunneling the connection, your friend is able to connect to the server running within your network.

Playit.gg/uninstall

#!/bin/bash

#Allow packages required by this app to be uninstalled
sudo apt remove playit || exit 1

theofficialgman commented 1 year ago

closing as stale as changes were requested over two weeks ago. This issue can be re-opened if changes are implemented.

Botspot / pi-apps