EDIT ME Include the app name and if it is a Package app or an Install based App

kidmakesreal commented 1 year ago

What is the name of the app?

Minecraft Pi Server

(Optional) Where is the app hosted?

No response

About the app

this is a one click installer for a minecraft pi edition server

Upload file or Add PR Link

minecraft_server.zip

Confirmations

[X] I have confirmed that this app is legal and not piracy.
[X] I have confirmed that this app has never been discussed in https://github.com/Botspot/pi-apps/issues and https://github.com/Botspot/pi-apps/pulls, and it is not in the Pi-Apps app list.
[X] I have confirmed that this app can run on Raspberry Pi.

github-actions[bot] commented 1 year ago

A zipfile was found in the body of your issue. The sha1sum of the zip was: ed6f79f5222c356870b73a3225d282afecff357a The contents can be previewed below:

minecraft_server/install.sh

#update os
sudo apt-get update

#create server folder
mkdir $HOME/mcpi_server
cd $HOME/mcpi_server

#download server
if $(uname -m | grep '64'); then
    echo "installing 64-bit"
    wget -O server.AppImage https://jenkins.thebrokenrail.com/job/minecraft-pi-reborn/job/master/257/artifact/out/minecraft-pi-reborn-server-2.4.7-arm64.AppImage
else
    echo "installing 32-bit"
    wget -O server.AppImage https://jenkins.thebrokenrail.com/job/minecraft-pi-reborn/job/master/257/artifact/out/minecraft-pi-reborn-server-2.4.7-armhf.AppImage

#make server executable
chmod +x server.AppImage

#make desktop shortcut
mkdir -p ~/.local/share/applications || error "Could not make directory"
echo "[Desktop Entry]
Name=Minecraft Pi Server
Exec=$HOME/mcpi_server/server.AppImage
Comment=Multiplayer Server
Terminal=true
Icon=$HOME/Minecraft Pi Server/mcpi_server_icon.png
Type=Application
Categories=Game;
" > ~/.local/share/applications/mcpi_server.desktop

fi

minecraft_server/uninstall.sh

rm -rf $HOME/mcpi_server/server.AppImage
rm $HOME/.local/share/applications/mcpi_server.desktop

github-actions[bot] commented 1 year ago

Hello there 👋 Thanks for submitting your first issue to the Pi-Apps project! We'll try to get back to you as soon as possible. In the meantime, we encourage you join our Discord server, where you can ask any questions you might have.

Please respond as soon as possible if a Pi-Apps maintainer requests more information from you. Stale issues will be closed after a lengthy period of time with no response.

Botspot commented 1 year ago

Cool. @NoozAbooz would you like to take a look at this one?

NoozAbooz commented 1 year ago

Cool. @NoozAbooz would you like to take a look at this one?

It's been quite awhile since I've looked here... I think gman is better suited than me to look at these. Just looking at the script however, it doesn't look like it conforms to Pi-Apps app standards.

@kidmakesreal I would suggest using the Pi-Apps app creator tool to remake the app (https://pi-apps.io/wiki/development/Creating-an-app/) and install the appimage in a way similiar to https://github.com/Botspot/pi-apps/blob/master/apps/Minecraft%20Pi%20(Modded)/install

Also adding @TheBrokenRail to this convo if he has anything he wants to add.

kidmakesreal commented 1 year ago

Cool. @NoozAbooz would you like to take a look at this one?

It's been quite awhile since I've looked here... I think gman is better suited than me to look at these. Just looking at the script however, it doesn't look like it conforms to Pi-Apps app standards.

@kidmakesreal I would suggest using the Pi-Apps app creator tool to remake the app (https://pi-apps.io/wiki/development/Creating-an-app/) and install the appimage in a way similiar to https://github.com/Botspot/pi-apps/blob/master/apps/Minecraft%20Pi%20(Modded)/install

Also adding @TheBrokenRail to this convo if he has anything he wants to add.

sorry it needed work i fixed it and put it here https://github.com/Botspot/pi-apps/issues/2434

Botspot / pi-apps