Open DatBoiG265 opened 9 months ago
@Botspot P.S even though i put a app request for this 2 years ago i have tidied up the scripts and followed your advice to make it a fully working script anyone can run this on there Raspberry Pi at the click of a button :)
Upload file or Add PR Link
Please use the proper issue template or actually provide a zip or PR link of which what you have provided is neither. As this is, this is an app suggestion, not an app submission. I have edited the post to use the app suggestion template.
App submissions should follow our developer documentation for making a pi-apps compatible submission https://pi-apps.io/wiki/development/Creating-an-app/
Will do
Here is the zip. Sorry for not understanding the first time what you meant. Have a good day :)
A zipfile was found in the body of an issue comment. The sha1sum of the zip was: 000da00e80f38c4ba1bf4b1cbe3fa6d01910dae7
Here is the zip. Sorry for not understanding the first time what you meant. Have a good day :)
You still do not understand what the format for the zip is. Pi-Apps applications must have particular install/uninstall scripts using standardized pi-apps functions. Again, please read the developer documentation https://pi-apps.io/wiki/development/Creating-an-app/ . Pi-Apps also has a "new app" GUI walkthrough available from the pi-apps settings that will help you develop an app for pi-apps.
Here is the zip. Sorry for not understanding the first time what you meant. Have a good day :)
You still do not understand what the format for the zip is. Pi-Apps applications must have particular install/uninstall scripts using standardized pi-apps functions. Again, please read the developer documentation https://pi-apps.io/wiki/development/Creating-an-app/ . Pi-Apps also has a "new app" GUI walkthrough available from the pi-apps settings that will help you develop an app for pi-apps.
Okay i will read through it again and make some changes. Thank you for letting me know what my mistakes are so i can learn from them and make my install/uninstall script better.
@theofficialgman @Botspot I have re made the install/uninstall script for old school runescape on linux so it can go on pi-apps by using the pi-apps app creator tool and my old shell script. I hope you like what i have done.
Have a good day :)
A zipfile was found in the body of an issue comment. The sha1sum of the zip was: 75c44bfed94618835535af10155ce30c68fecf1d
The zip is entirely empty.
Also there is no need to @ the developers each time. We already get notifications.
The zip is entirely empty.
Also there is no need to @ the developers each time. We already get notifications.
Sorry Also I will quickly fix that
Here's the fixed zip file.
A zipfile was found in the body of an issue comment. The sha1sum of the zip was: e6324da42c52474b541e51f4363dc0f9a3b0e547
I have got a video of the script running through pi-apps on my raspberry pi. Also i had to edit it so it would be less than 10mb to upload to github so sorry about it being low quality. Here it is
https://github.com/Botspot/pi-apps/assets/100205162/ba545bd1-caf0-4d0f-a8ca-678700dbbcad
Please again refer to the documentation https://pi-apps.io/wiki/development/Creating-an-app/ There are many issues with your script that I hoped you would solve by reading that already.
The biggest one is don't use apt directly, refer to the documentation for what to use. Additionally, we prefer that applications be installed globally and definitely not in their own custom directory in the home folder. There are a lot of other scripts in pi-apps that do this already, you can search for some on github by looking for /usr/share/applications
Please again refer to the documentation https://pi-apps.io/wiki/development/Creating-an-app/ There are many issues with your script that I hoped you would solve by reading that already.
The biggest one is don't use apt directly, refer to the documentation for what to use. Additionally, we prefer that applications be installed globally and definitely not in their own custom directory in the home folder. There are a lot of other scripts in pi-apps that do this already, you can search for some on github by looking for
/usr/share/applications
I will follow you advice and edit the script and make it better :)
Here is the zip. Runelite (OSRS).zip
I had to follow the the documentation on https://pi-apps.io/wiki/development/Creating-an-app/ for a bit of help but i think this is ready to be put on pi-apps :)
A zipfile was found in the body of an issue comment. The sha1sum of the zip was: c1fcc4ff71b68946e39bbd9dd01fdbe2d21869ce
Had to update the description but here is the zip file for my app. Hope you like it :) Runelite (OSRS).zip
A zipfile was found in the body of an issue comment. The sha1sum of the zip was: cf27f9102f2584c6e5a95870c3cf4710a41735bc
Better. However you still missing error handling on install_packages (refer to the documentation again)
And again, we would prefer that applications be installed globally. Use the github search for /usr/share/applications
in this repo and you will find many applications that install their .desktop files globally and their jars and other binaries globally.
Also, is this folder used for save data? rm -rf $HOME/.runelite/
Pi-Apps has a rule that no uninstall script should delete user data.
Also, is this folder used for save data?
rm -rf $HOME/.runelite/
Pi-Apps has a rule that no uninstall script should delete user data.
Its the clients save data but old school runescape saves you save data to the cloud through jagex account.
Should I change it so the clients save data stays on the raspberry pi 4 after being uninstalled?
Better. However you still missing error handling on install_packages (refer to the documentation again)
And again, we would prefer that applications be installed globally. Use the github search for
/usr/share/applications
in this repo and you will find many applications that install their .desktop files globally and their jars and other binaries globally.
I will change that and send you and updated zip with the scripts in
Should I change it so the clients save data stays on the raspberry pi 4 after being uninstalled?
yes please.
Should I change it so the clients save data stays on the raspberry pi 4 after being uninstalled?
yes please.
Will do thanks for the advice :)
I have fixed what you told me to do with the script and looked at the pi-apps documentation for help with it anyway, Here is the updated zip with my script.
A zipfile was found in the body of an issue comment. The sha1sum of the zip was: 77377c73eb71de02dbc1057c686de36f28262980
never mind i forgot to save one thing in it i will send you another updated one
Here is the zip again after my silly mistake.
A zipfile was found in the body of an issue comment. The sha1sum of the zip was: f285a9bfa8aa403f40d1a0be479731851bd43cb9
Never mind after looking at the uninstall script I have done another silly mistake 😅 I'll fix it
Here is the zip after that silly mistake revolving the desktop entry not deleting on the last zip i sent you.
Sorry if it seems like i'm spamming.
A zipfile was found in the body of an issue comment. The sha1sum of the zip was: 95bf725a0b6fc93d43f0fc257033a44418bc9980
A zipfile was found in the body of an issue comment. The sha1sum of the zip was: 95bf725a0b6fc93d43f0fc257033a44418bc9980
Click to show contents preview
`install` ```bash #!/bin/bash cd $HOME mkdir RuneLite cd RuneLite #Download install_packages openjdk-17-jdk || exit 1 git clone https://github.com/DatBoiG265/RuneScape-on-Linux || error 'Failed to download clone repository!' cd RuneScape-on-Linux cp RuneLite.jar $HOME/RuneLite rm -rf $HOME/RuneLite/RuneScape-on-Linux/ #Desktop shortcut echo "[Desktop Entry] Name=RuneLite Comment=Open Source RuneScape Launcher Icon=$(dirname "$0")/icon-64.png Exec=java -jar $HOME/RuneLite/RuneLite.jar Path=$HOME/RuneLite/ Type=Application Encoding=UTF-8 Terminal=false StartupNotify=true Categories=Game;" | sudo tee /usr/share/applications/RuneLite-OSRS.desktop || error "Failed to create menu button!" echo "If there are any issues please open an issue on this repository:https://github.com/DatBoiG265/RuneScape-on-Linux. To run: Menu -> Games -> RuneLite" ``` `credits` ``` Old School Runescape is by Jagex Runelite is by Runelite.net install/uninstall Script made by: DatBoiG265 ``` `website` ``` https://github.com/DatBoiG265/RuneScape-on-Linux ``` `description` ``` Old School RuneScape is a massively multiplayer online role-playing game (MMORPG) To run:Menu->Games->Runelite To run in terminal: java -jar /home/$HOME/games/RuneLite/RuneLite.jar Need help? Please open an issue on this repository: https://github.com/DatBoiG265/RuneScape-on-Linux ``` `uninstall` ```bash #!/bin/bash #Uninstalling rm -rf $HOME/RuneLite/ sudo rm -rf /usr/share/applications/RuneLite-OSRS.desktop || error "Failed to remove menu button!" #Allow packages required by this app to be uninstalled purge_packages || exit 1 ```
😑 I have just Realized a mistake in the description i have done i will fix it now
A zipfile was found in the body of an issue comment. The sha1sum of the zip was: 95bf725a0b6fc93d43f0fc257033a44418bc9980
Click to show contents preview
install
#!/bin/bash cd $HOME mkdir RuneLite cd RuneLite #Download install_packages openjdk-17-jdk || exit 1 git clone https://github.com/DatBoiG265/RuneScape-on-Linux || error 'Failed to download clone repository!' cd RuneScape-on-Linux cp RuneLite.jar $HOME/RuneLite rm -rf $HOME/RuneLite/RuneScape-on-Linux/ #Desktop shortcut echo "[Desktop Entry] Name=RuneLite Comment=Open Source RuneScape Launcher Icon=$(dirname "$0")/icon-64.png Exec=java -jar $HOME/RuneLite/RuneLite.jar Path=$HOME/RuneLite/ Type=Application Encoding=UTF-8 Terminal=false StartupNotify=true Categories=Game;" | sudo tee /usr/share/applications/RuneLite-OSRS.desktop || error "Failed to create menu button!" echo "If there are any issues please open an issue on this repository:https://github.com/DatBoiG265/RuneScape-on-Linux. To run: Menu -> Games -> RuneLite"
credits
Old School Runescape is by Jagex Runelite is by Runelite.net install/uninstall Script made by: DatBoiG265
website
https://github.com/DatBoiG265/RuneScape-on-Linux
description
Old School RuneScape is a massively multiplayer online role-playing game (MMORPG) To run:Menu->Games->Runelite To run in terminal: java -jar /home/$HOME/games/RuneLite/RuneLite.jar Need help? Please open an issue on this repository: https://github.com/DatBoiG265/RuneScape-on-Linux
uninstall
#!/bin/bash #Uninstalling rm -rf $HOME/RuneLite/ sudo rm -rf /usr/share/applications/RuneLite-OSRS.desktop || error "Failed to remove menu button!" #Allow packages required by this app to be uninstalled purge_packages || exit 1
😑 I have just Realized a mistake in the description i have done i will fix it now
Fixed it all now. Finally anyway here's the zip. Runelite (OSRS).zip
A zipfile was found in the body of an issue comment. The sha1sum of the zip was: a0a0f9153d025811c9a8a200666024ad2e987479
i have just realized another thing i have messed up anyway mi going to fix it.
A zipfile was found in the body of an issue comment. The sha1sum of the zip was: f2f8e163f935ab824dac42b3ca5952bc3f87ef72
Sorry it was unfair to have some of our reference scripts not install globally as is our current intention. Please refer to Shattered Pixel Dungeon (which I have just updated) which is our new "gold standard" for global installs going forward for java applications such as this one you want to add https://github.com/Botspot/pi-apps/tree/master/apps/Shattered%20Pixel%20Dungeon
Sorry it was unfair to have some of our reference scripts not install globally as is our current intention. Please refer to Shattered Pixel Dungeon (which I have just updated) which is our new "gold standard" for global installs going forward for java applications such as this one you want to add https://github.com/Botspot/pi-apps/tree/master/apps/Shattered%20Pixel%20Dungeon
Okay
I have looked at both install/uninstall scripts for Shattered Pixel Dungeon to see what i could change on my install/uninstall script. Here's the zip.
A zipfile was found in the body of an issue comment. The sha1sum of the zip was: 69d6d6ab1fdd84dc95b86a23db11d7d49dadc64b
You are missing the point. your install is not global. Your files (game and icon) reside in the specific users home folder $HOME/RuneLite
and Icon=$(dirname "$0")/icon-64.png
Please refer again to shattered pixel dungeon. it is a perfect match for runscape. All you need to do is take those scripts and change the links/paths for runescape
You are missing the point. your install is not global. Your files (game and icon) reside in the specific users home folder
$HOME/RuneLite
andIcon=$(dirname "$0")/icon-64.png
Please refer again to shattered pixel dungeon. it is a perfect match for runscape. All you need to do is take those scripts and change the links/paths for runescape
Thank for letting me know what I did wrong I will fix it :)
I have actually made the install global now. Thank you for the help here is the zip.
A zipfile was found in the body of an issue comment. The sha1sum of the zip was: 456ff3a5520765e9a99302cf5d2675fc5e9a4b80
better. I will ignore the remaining issues with the script global installation for now. Lets discuss the issues with obtaining runscape
sudo git clone https://github.com/DatBoiG265/RuneScape-on-Linux || error 'Failed to download clone repository!'
cd /usr/local/share/RuneLite/RuneScape-on-Linux
sudo cp RuneLite.jar /usr/local/share/RuneLite
sudo rm -rf /usr/local/share/RuneLite/RuneScape-on-Linux/
Why are we cloning your git repo? runelite is available from upstream directly -> https://github.com/runelite/launcher/releases/tag/2.6.10 which is what is linked on the website https://runelite.net/ Newer tags/releases are macOS only just because they were fixing macOS only bugs.
better. I will ignore the remaining issues with the script global installation for now. Lets discuss the issues with obtaining runscape
sudo git clone https://github.com/DatBoiG265/RuneScape-on-Linux || error 'Failed to download clone repository!' cd /usr/local/share/RuneLite/RuneScape-on-Linux sudo cp RuneLite.jar /usr/local/share/RuneLite sudo rm -rf /usr/local/share/RuneLite/RuneScape-on-Linux/
Why are we cloning your git repo? runelite is available from upstream directly -> https://github.com/runelite/launcher/releases/tag/2.6.10 which is what is linked on the website https://runelite.net/ Newer tags/releases are macOS only just because they were fixing macOS only bugs.
Because I don't know how to clone a release without using wget which the pi-apps documentation says not to.
Is there a way to clone releases? If so, could you tell me how?
What is the name of the app?
Runelite (OSRS)
(Optional) Where is the app hosted?
https://github.com/DatBoiG265/RuneScape-on-Linux
About the app
A Script that installs Runelite an Old School RuneScape client onto your Raspberry Pi
Tested on Raspberry pi 4 Model B (4gb) with Raspberry pi os Bookworm 64bit
Confirmations