Numbat: Install based app

archisman-panigrahi commented 1 month ago

What is the name of the app?

numbat

Where is the app hosted?

New versions are hosted in https://github.com/sharkdp/numbat

About the app

Numbat is a an excellent scientific calculator that supports physical units.

Upload file or Add PR Link

Numbat.zip

https://github.com/sharkdp/numbat/releases/tag/v1.11.0

Confirmations

[X] I have confirmed that this app is legal and not piracy.
[X] I have confirmed that this app has never been discussed in https://github.com/Botspot/pi-apps/issues and https://github.com/Botspot/pi-apps/pulls, and it is not in the Pi-Apps app list.
[X] I have read and followed the creating an app for Pi-Apps documentation.
[X] I have confirmed that this app can run on all Pi-Apps supported systems.

Botspot commented 1 month ago

Would you be willing to follow our app creation guidelines so that the app icon, installation scripts, description, and website url are given appropriate values? https://pi-apps.io/wiki/development/Creating-an-app/

Botspot commented 1 month ago

Also, I'm assuming you are a Pi-Apps user. Do you think it would fit better under Tools, Engineering, Office, or somewhere else? We currently do not have a dedicated Mathematics category.

archisman-panigrahi commented 1 month ago

Also, I'm assuming you are a Pi-Apps user. Do you think it would fit better under Tools, Engineering, Office, or somewhere else? We currently do not have a dedicated Mathematics category.

The Engineering category.

archisman-panigrahi commented 1 month ago

Would you be willing to follow our app creation guidelines so that the app icon, installation scripts, description, and website url are given appropriate values? https://pi-apps.io/wiki/development/Creating-an-app/

The deb file automatically installs an icon and a .desktop file.

Icon link: https://github.com/sharkdp/numbat/blob/master/assets/numbat.svg description: Numbat is a statically typed programming language for scientific computations with first class support for physical dimensions and units. website: https://github.com/sharkdp/numbat

Botspot commented 1 month ago

Have you used Pi-Apps? Pi-Apps needs you to give it a description. We have a template for this. Pi-Apps needs specific icon sizes placed in the app folder, given specific filenames.

Can't quite tell if you are refusing to read our docs or if you plan to work on this later.

archisman-panigrahi commented 1 month ago

Sorry, I didn't realize I have to create the zip file using Pi-Apps. I will get back soon.

Botspot commented 1 month ago

Sorry, I didn't realize I have to create the zip file using Pi-Apps. I will get back soon.

You don't have to, but we do request that you follow the app folder format so we don't have to do it for you.

github-actions[bot] commented 1 month ago

A zipfile was found in the body of your issue. The sha1sum of the zip was: 945be5f70ba98d25417dab42dab81ad97ac7aa67

Click to show contents preview

`description` ``` Scientific calculator with first class support for physical dimensions and units. Numbat can be run from the app menu, as well as by entering the command numbat in the terminal. Numbat can be utilized to convert almost any units to any units. For example, if you want to convert 5 feet to cm, run "5 ft -> cm" in numbat. Moreover, Numbat knows the values of all frequently used scientific constants like the speed of light, Planck constant, Boltzmann constant, and so on. For more details see https://numbat.dev/doc/ ``` `install-32` ```bash #!/bin/bash version=1.11.0 install_packages https://github.com/sharkdp/numbat/releases/download/v${version}/numbat_${version}_armhf.deb || exit 1 ``` `uninstall` ```bash #!/bin/bash #Allow packages required by this app to be uninstalled purge_packages || exit 1 ``` `credits` ``` Who deserves credit for making this app? David Peter Who deserves credit for putting it on Pi-Apps? Archisman Panigrahi ``` `install-64` ```bash #!/bin/bash version=1.11.0 install_packages https://github.com/sharkdp/numbat/releases/download/v${version}/numbat_${version}_arm64.deb || exit 1 ``` `website` ``` https://github.com/sharkdp/numbat ```

archisman-panigrahi commented 1 month ago

I have updated the zip file. I am reopening the issue

theofficialgman commented 1 month ago

Passes installation CI on all supported systems https://github.com/Botspot/pi-apps/actions/runs/9131925909

I checked the debs and they have no dependencies in the control file. That should be corrected upstream before this can be included as these do depend on GLIBC (minimum version differs depending on the architecture). Please open a bug report of that upstream @archisman-panigrahi and link back here. They can use the standard debian packaging tool dpkg-shlibdeps to automatically determine the binary dependencies.

archisman-panigrahi commented 1 month ago

AFAIK glibc is the only dependency, and AFAIK, all recent versions of glibc work. Is it really necessary to have it in the .deb package as an explicit dependency for inclusion in pi-apps, given all the supported distros (Raspberry Pi OS/Ubuntu) have glibc preinstalled and that is not going to change anytime soon?

theofficialgman commented 1 month ago

Having the proper dependencies listed allows our CI and users to verify that the binary will work on their system. If something changes on the build end future builds could result in a much higher glibc requirement (eg: 2.38) and there would be no way for our CI to catch such issues and prevent upgrades.

It's best practice for 3rd party packages and a requirement for real debian/Ubuntu packages.

archisman-panigrahi commented 1 month ago

Here is the upstream issue https://github.com/sharkdp/numbat/issues/434#issue-2304367847

Botspot / pi-apps