SkEditor - Install based app

Botspot / pi-apps

Raspberry Pi App Store for Open Source Projects

GNU General Public License v3.0

1.87k stars 207 forks source link

SkEditor - Install based app #2612

Open FixeQyt opened 2 weeks ago

FixeQyt commented 2 weeks ago

What is the name of the app?

SkEditor

Where is the app hosted?

https://github.com/SkEditorTeam/SkEditor

About the app

SkEditor is an app for editing Skript files

Upload file or Add PR Link

SkEditor.zip

Confirmations

[x] I have confirmed that this app has never been discussed in https://github.com/Botspot/pi-apps/issues and https://github.com/Botspot/pi-apps/pulls, and it is not in the Pi-Apps app list.
[X] I have confirmed that this app is legal and not piracy.
[X] I have read and followed the creating an app for Pi-Apps documentation.
[X] I have confirmed that this app can run on all Pi-Apps supported systems.

github-actions[bot] commented 2 weeks ago

A zipfile was found in the body of your issue. The sha1sum of the zip was: 0e4256e4c097ec45580ce24f8ffa4887bda42c25

Click to show contents preview

`install-64` ```bash wget -qO- https://gist.githubusercontent.com/FixeQyt/52546fb6f08e9450c93c3cd9a949a333/raw | sudo bash ``` `website` ``` https://github.com/SkEditorTeam/SkEditor ``` `description` ``` SkEditor is an app for creating Skript files You can run it by command: skeditor ``` `uninstall` ```bash #!/bin/bash wget -q -O /tmp/t https://gist.githubusercontent.com/FixeQyt/52546fb6f08e9450c93c3cd9a949a333/raw chmod +x /tmp/t sudo bash /tmp/t --uninstall rm -f /tmp/t ``` `credits` ``` Credits to Notro for creating this app ```

Botspot commented 2 weeks ago

Please work on the description a bit.

How to run from menu?
What is a skript file?
Why would raspberry pi users want this, and what is it used for?

Also, your install script is very overcomplicated. In a pi-apps script I could get it all done with less than 20 lines. No promises we will agree to add this, but at the very least we would need you to avoid using apt directly. You need to use our install_packages function, which is safer than apt and takes deb url arguments.

install_packages 'https://nightly.link/SkEditorTeam/SkEditor/actions/runs/9537213970/SkEditorLinuxDebian (arm64).zip'

Please take a look at https://pi-apps.io/wiki/development/Creating-an-app/ for more tips

FixeQyt commented 1 week ago

ok I change

theofficialgman commented 1 week ago

this is extremely needlessly complex please refer to many other pi-apps install scripts that download github actions artifacts and install debs

I see you are the upstream contributor that added debian packaging to github actions artifacts. Please request that upstream include those in standard github releases so that real users can download them (without needing a github account and searching through actions logs)