update-exclusion failing

Botspot / pi-apps

Raspberry Pi App Store for Open Source Projects

GNU General Public License v3.0

1.95k stars 204 forks source link

update-exclusion failing #649

Closed NoozAbooz closed 3 years ago

NoozAbooz commented 3 years ago

I'm on Twister OS.

update-exclusion has this:

apps/Wine (x86)/
apps/Steam

I recently noticed that Wine got an update even when it's not supposed to. I tested this with manually triggering a reinstall with the update system, and it still reinstalled wine even though it's not supposed to.

Botspot commented 3 years ago

I'm on Twister OS.

update-exclusion has this:
apps/Wine (x86)/
apps/Steam
I recently noticed that Wine got an update even when it's not supposed to.

That's not good. Thank you very much for letting me know. (last thing we need is another round of that.) What happens if update-exclusion is changed to this?

apps/Wine (x86)
apps/Steam

NoozAbooz commented 3 years ago

I'm on Twister OS. update-exclusion has this:
apps/Wine (x86)/
apps/Steam
I recently noticed that Wine got an update even when it's not supposed to.
That's not good. Thank you very much for letting me know. (last thing we need is another round of that.) What happens if update-exclusion is changed to this?
apps/Wine (x86)
apps/Steam

Same thing.

Itai-Nelken commented 3 years ago

maybe

apps/Wine\ (x86)
apps/Steam

@mobilegmYT

NoozAbooz commented 3 years ago

maybe
apps/Wine\ (x86)
apps/Steam
@mobilegmYT

Ayy it worked now! @Botspot Just change whatever pi-apps does to add Wine to the list, to the stuff above ^

Botspot commented 3 years ago

maybe
apps/Wine\ (x86)
apps/Steam
@mobilegmYT
Ayy it worked now! @Botspot Just change whatever pi-apps does to add Wine to the list, to the stuff above ^

Hmm. It shouldn't need that slash. It means something isn't being quoted properly.

NoozAbooz commented 3 years ago

maybe
apps/Wine\ (x86)
apps/Steam
@mobilegmYT
Ayy it worked now! @Botspot Just change whatever pi-apps does to add Wine to the list, to the stuff above ^
Hmm. It shouldn't need that slash. It means something isn't being quoted properly.

Pretty sure even if bash does quote it, it still needs more quotes for it to work. Hence why I have to do ~/pi-apps/manage install Wine\ (x86) and not ~/pi-apps/manage install Wine (x86)

Botspot commented 3 years ago

Pretty sure even if bash does quote it, it still needs more quotes for it to work. Hence why I have to do ~/pi-apps/manage install Wine\ (x86) and not ~/pi-apps/manage install Wine (x86)

Hence why you should do ~/pi-apps/manage install 'Wine (x86)'

Itai-Nelken commented 3 years ago

@mobilegmYT commits https://github.com/Botspot/pi-apps/compare/765275e38170...cdfe0ebd8f1d should fix it, Update and try again.

Botspot commented 3 years ago

@mobilegmYT update-exclusion only applies to individual files, not apps. The new way Wine is prevented from being installed on TwisterOS is by marking it as disabled.