Open kyhule opened 2 years ago
After creating this issue, I thought that I should actually look at the source code which led me to seeing this: https://github.com/BreadMoirai/github-release-gradle-plugin/blob/1e0d2ca36f29173e61b79b44fc01ad1ca3ee9f71/src/main/groovy/com/github/breadmoirai/githubreleaseplugin/ChangeLogSupplier.groovy#L99-L102 So that confirms that an error thrown while retrieving the releases would in fact do so silently. I suppose that I can increase the timeouts by providing my own okhttp client and see if that improves things.
As for the silent error handling, it would be nice to see some sort of messaging that something went wrong.
I recently integrated this plugin into a project and had success with it while testing the integration with
dryRun
as well as against a fork of the project but when I eventually merged the changes to main and ran the release process, the changelogs were empty. I just rangithubRelease
again twice locally withdryRun
enabled and the first run resulted in no changelogs while the second had them. Nothing changed between runs. It seems as though the first run failed to get the previous releases. Is it possible that the request timed out silently?First run:
Second run: