Closed limingzhou2004 closed 2 years ago
A couple of housekeeping comments, in addition to the outstanding comments on the code itself:
Control_Areas.zip
is no longer used, but still in the repo. Is this needed, or can it be removed?NYISO downstate.geojson
file (and the space in the filename should probably be removed to match the naming convention for the rest of the repo).If there are files that we used to have, but are no longer included, then we'll want to remove those entries from the Attribution file (e.g. ercot_zone_mapping.csv
, isone.zip
).
Pull Request doc
Purpose
What is the larger goal of this change? The code generate a map of Control Areas, ISO subregions, and geographical zones, for spatial load assignment.
What the code is doing
How is the purpose executed? From the existing BA_County_map.json, we add the subregions of NYISO, ISONE, ERCOT, CISO, PJM. The CA/subregional level load is matched to this map. A matching table is created to allocate the load based on the overlapping area.
Testing
How did you test this change (unit/functional testing, manual testing, etc.)? To test, run python -m prereise.gather.data.remap_ba_area.remap_ba_area
Where to look
Usage Example/Visuals
How the code can be used and/or images of any graphs, tables or other visuals (not always applicable). Three files will be generated: remap_ba_area.shp, zenodo_map_to_ca.csv, remap_ba_area.tif
Time estimate
How long will it take for reviewers and observers to understand this code change? 20 min