Breakthrough-Energy / PreREISE

Generate input data for scenario framework
https://breakthrough-energy.github.io/docs/
MIT License
21 stars 28 forks source link

feat: use transmission line physical parameters to calculate impedances and ratings for HIFLD grid #276

Closed danielolsen closed 2 years ago

danielolsen commented 2 years ago

Pull Request doc

Purpose

To build branch ratings and impedances for the HIFLD grid, use assumptions which start with the physical parameters of typical line designs (with non-typical overrides as necessary), rather than relying on processed averages from the TAMU grid.

What the code is doing

Testing

Tested manually to build the HIFLD grid. Preliminary tests show the built grid having much less transmission violation energy and many fewer lines violating, compared to when the grid is built using the assumed values from the TAMU data. Full results to be added later.

~Unit tests still need to be updated.~ EDIT: done.

Usage Example/Visuals

All code changes will be used by calling the build_transmission function (either directly or via create_csvs or create_grid in the orchestration module).

Time estimate

30 minutes to an hour, provided they already have a good understanding of the line parameter calculation logic, or are willing to trust the previous reviews of that code (#272). ~This branch depends on #272, so is a draft for now.~

danielolsen commented 2 years ago

With #272 merged and tests updated, this branch is now ready for a full review.

danielolsen commented 2 years ago

Thanks for adding those tests!

I was bored on a plane with no wifi.