Breakthrough-Energy / PreREISE

Generate input data for scenario framework
https://breakthrough-energy.github.io/docs/
MIT License
21 stars 28 forks source link

feat: add file with immediate charging adjustment values #288

Closed isond closed 2 years ago

isond commented 2 years ago

Pull Request doc

Purpose

What is the larger goal of this change? To add the file containing the adjustment values/scaling factors for the immediate charging code.

What the code is doing

How is the purpose executed?

Testing

How did you test this change (unit/functional testing, manual testing, etc.)?

Where to look

Usage Example/Visuals

How the code can be used and/or images of any graphs, tables or other visuals (not always applicable).

Time estimate

How long will it take for reviewers and observers to understand this code change?

rouille commented 2 years ago

One every other row, month is not set. If I understand correctly, these entries are related to weekends (weekday == False) and hence I don't understand why these entries cannot have the month set.

danielolsen commented 2 years ago

One every other row, month is not set. If I understand correctly, these entries are related to weekends (weekday == False) and hence I don't understand why these entries cannot have the month set.

It might be related to how MultiIndexes are displayed. Maybe it can also be loaded into pandas this way, but filled months would probably be clearer.

danielolsen commented 2 years ago

Superseded by #298