Breakthrough-Energy / PreREISE

Generate input data for scenario framework
https://breakthrough-energy.github.io/docs/
MIT License
20 stars 28 forks source link

feat/data: update HIFLD data to April 2022 version, refactor line assignment #289

Closed danielolsen closed 2 years ago

danielolsen commented 2 years ago

Pull Request doc

Purpose

What the code is doing

Testing

Tested manually to generate static grid components. ~The resulting static grid components haven't been tested for network feasibility yet, so we may also need to update some of the line assumptions that were introduced in #276.~ EDIT: update: the results of this new code have been tested alongside the new code in #286 and new line/substation assumptions have been added which seem to ensure generator-side feasibility.

Usage Example/Visuals

The call signature to map_lines_to_substations_using_coords remains the same, we just add one more optional parameter that controls how far away from any substation a line's endpoint can be before we create a new proxy substation for it (instead of connecting it to an existing one).

Time estimate

30 minutes? The code changes are fairly light, most of the changes are in the constants which required a tedious guess-and-check process. ~This is a draft PR for now, since the functionality depends partially on #283, and since we may want to make some modifications to the underlying logic, but the code that's here creates the interconnections as we expect.~ EDIT: #283 is merged, so this is ready to go.

danielolsen commented 2 years ago

I'm going to wait to finish/merge this until #286 is merged, since the updates for feasibility don't work by themselves without the #286 logic. EDIT feasibility updates also depend on #292, which depends on #286, so I think the preferred merge order is: #286, #292, #289.